Issue 138033013: Add script to tools/security to check consistency of message file owners.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138033013: Add script to tools/security to check consistency of message file owners. (Closed)

Created:
6 years, 11 months ago by Tom Sepez

Modified:
6 years, 11 months ago

Reviewers:
jschuh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add script to tools/security to check consistency of message file owners. Periodic use of this script will show places where the OWNERS files have become inconsistent. This poses a problem for CL authors when the reviewer they have selected doesn't cover all message files, so they would have to add another. I've stopped short of adding code to correct the files, this would make a nice follow-up. R=jschuh@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245320

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -0 lines)			Patch
	A	tools/security/check_message_owners.py	View	1 2 3 4 5 6	1 chunk	+53 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

Justin, please review, since you have context on this.

6 years, 11 months ago (2014-01-16 20:02:11 UTC) #1

jschuh

On 2014/01/16 20:02:11, Tom Sepez wrote: > Justin, please review, since you have context on ...

6 years, 11 months ago (2014-01-16 20:12:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/138033013/140001

6 years, 11 months ago (2014-01-16 20:16:46 UTC) #3

Tom Sepez

6 years, 11 months ago (2014-01-16 21:08:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #7 manually as r245320 (presubmit successful).

Expand Messages | Collapse Messages

Issue 138033013: Add script to tools/security to check consistency of message file owners. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fewer list-to-set conversions #

Patch Set 3 : copyright 2013 #

Patch Set 4 : deal with possibility of #-style comment following reviewer name #

Patch Set 5 : fix two-space indentation #

Patch Set 6 : does anyone really know what year it is? #

Patch Set 7 : main() return value #

Messages