Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138033012: Deopt marked code at safe deoptimization point when pretenuring. (Closed)

Created:
6 years, 11 months ago by Hannes Payer (out of office)
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Deopt marked code at safe deoptimization point when pretenuring. BUG= R=bmeurer@chromium.org, mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18641

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -12 lines) Patch
M src/execution.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/execution.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M src/heap.cc View 4 chunks +10 lines, -7 lines 2 comments Download
M src/objects-inl.h View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Hannes Payer (out of office)
6 years, 11 months ago (2014-01-16 10:42:06 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/138033012/diff/10001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/138033012/diff/10001/src/heap.cc#newcode535 src/heap.cc:535: if (site->GetPretenureMode() == TENURED) { Shouldn't this if still ...
6 years, 11 months ago (2014-01-16 11:19:37 UTC) #2
Benedikt Meurer
LGTM
6 years, 11 months ago (2014-01-16 11:40:19 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/138033012/diff/10001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/138033012/diff/10001/src/heap.cc#newcode535 src/heap.cc:535: if (site->GetPretenureMode() == TENURED) { On 2014/01/16 11:19:37, Benedikt ...
6 years, 11 months ago (2014-01-16 11:41:19 UTC) #4
mvstanton
lgtm
6 years, 11 months ago (2014-01-16 11:52:55 UTC) #5
Hannes Payer (out of office)
6 years, 11 months ago (2014-01-16 11:54:22 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 manually as r18641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698