Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138033007: Limit using full paths in the directory model in the Files app. (Closed)

Created:
6 years, 11 months ago by mtomasz
Modified:
6 years, 11 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Limit using full paths in the directory model in the Files app. This patch converts methods getLeadPath, setLeadPath, getSelectedPaths and setSelectedPaths to *Entry/*Entries. TEST=Tested manually. Partly browser tests. BUG=320967 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245462

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -30 lines) Patch
M chrome/browser/resources/file_manager/foreground/js/directory_model.js View 1 4 chunks +19 lines, -30 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtomasz
@hirono: PTAL. Thanks!
6 years, 11 months ago (2014-01-16 05:56:41 UTC) #1
hirono
https://codereview.chromium.org/138033007/diff/1/chrome/browser/resources/file_manager/foreground/js/directory_model.js File chrome/browser/resources/file_manager/foreground/js/directory_model.js (right): https://codereview.chromium.org/138033007/diff/1/chrome/browser/resources/file_manager/foreground/js/directory_model.js#newcode220 chrome/browser/resources/file_manager/foreground/js/directory_model.js:220: if (urls.indexOf(fileList.item(i).toURL())) !== -1 is needed?
6 years, 11 months ago (2014-01-17 03:11:29 UTC) #2
mtomasz
https://codereview.chromium.org/138033007/diff/1/chrome/browser/resources/file_manager/foreground/js/directory_model.js File chrome/browser/resources/file_manager/foreground/js/directory_model.js (right): https://codereview.chromium.org/138033007/diff/1/chrome/browser/resources/file_manager/foreground/js/directory_model.js#newcode220 chrome/browser/resources/file_manager/foreground/js/directory_model.js:220: if (urls.indexOf(fileList.item(i).toURL())) On 2014/01/17 03:11:29, hirono wrote: > !== ...
6 years, 11 months ago (2014-01-17 04:16:42 UTC) #3
hirono
On 2014/01/17 04:16:42, mtomasz wrote: > https://codereview.chromium.org/138033007/diff/1/chrome/browser/resources/file_manager/foreground/js/directory_model.js > File chrome/browser/resources/file_manager/foreground/js/directory_model.js > (right): > > https://codereview.chromium.org/138033007/diff/1/chrome/browser/resources/file_manager/foreground/js/directory_model.js#newcode220 ...
6 years, 11 months ago (2014-01-17 05:03:42 UTC) #4
mtomasz
On 2014/01/17 05:03:42, hirono wrote: > On 2014/01/17 04:16:42, mtomasz wrote: > > > https://codereview.chromium.org/138033007/diff/1/chrome/browser/resources/file_manager/foreground/js/directory_model.js ...
6 years, 11 months ago (2014-01-17 05:06:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/138033007/100001
6 years, 11 months ago (2014-01-17 05:07:29 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 07:16:34 UTC) #7
Message was sent while issue was closed. 
Change committed as 245462

Powered by Google App Engine
This is Rietveld 408576698