Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: runtime/vm/snapshot_test.cc

Issue 138033002: Make VM TypedList not implement ByteBuffer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove cast. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service_test.cc ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot_test.cc
diff --git a/runtime/vm/snapshot_test.cc b/runtime/vm/snapshot_test.cc
index 365d9e0d42e5ee105197785d9be5da6b2124fb4f..aebebd219cca61647edb5669def908aab2e3bf59 100644
--- a/runtime/vm/snapshot_test.cc
+++ b/runtime/vm/snapshot_test.cc
@@ -2403,44 +2403,44 @@ UNIT_TEST_CASE(DartGeneratedListMessagesWithTypedData) {
"getTypedDataViewList() {\n"
" var list = new List(30);\n"
" var index = 0;\n"
- " list[index++] = new Int8List.view(new Int8List(256));\n"
- " list[index++] = new Uint8List.view(new Uint8List(256));\n"
- " list[index++] = new Int16List.view(new Int16List(256));\n"
- " list[index++] = new Uint16List.view(new Uint16List(256));\n"
- " list[index++] = new Int32List.view(new Int32List(256));\n"
- " list[index++] = new Uint32List.view(new Uint32List(256));\n"
- " list[index++] = new Int64List.view(new Int64List(256));\n"
- " list[index++] = new Uint64List.view(new Uint64List(256));\n"
- " list[index++] = new Float32List.view(new Float32List(256));\n"
- " list[index++] = new Float64List.view(new Float64List(256));\n"
-
- " list[index++] = new Int8List.view(new Int16List(256));\n"
- " list[index++] = new Uint8List.view(new Uint16List(256));\n"
- " list[index++] = new Int8List.view(new Int32List(256));\n"
- " list[index++] = new Uint8List.view(new Uint32List(256));\n"
- " list[index++] = new Int8List.view(new Int64List(256));\n"
- " list[index++] = new Uint8List.view(new Uint64List(256));\n"
- " list[index++] = new Int8List.view(new Float32List(256));\n"
- " list[index++] = new Uint8List.view(new Float32List(256));\n"
- " list[index++] = new Int8List.view(new Float64List(256));\n"
- " list[index++] = new Uint8List.view(new Float64List(256));\n"
-
- " list[index++] = new Int16List.view(new Int8List(256));\n"
- " list[index++] = new Uint16List.view(new Uint8List(256));\n"
- " list[index++] = new Int16List.view(new Int32List(256));\n"
- " list[index++] = new Uint16List.view(new Uint32List(256));\n"
- " list[index++] = new Int16List.view(new Int64List(256));\n"
- " list[index++] = new Uint16List.view(new Uint64List(256));\n"
- " list[index++] = new Int16List.view(new Float32List(256));\n"
- " list[index++] = new Uint16List.view(new Float32List(256));\n"
- " list[index++] = new Int16List.view(new Float64List(256));\n"
- " list[index++] = new Uint16List.view(new Float64List(256));\n"
+ " list[index++] = new Int8List.view(new Int8List(256).buffer);\n"
+ " list[index++] = new Uint8List.view(new Uint8List(256).buffer);\n"
+ " list[index++] = new Int16List.view(new Int16List(256).buffer);\n"
+ " list[index++] = new Uint16List.view(new Uint16List(256).buffer);\n"
+ " list[index++] = new Int32List.view(new Int32List(256).buffer);\n"
+ " list[index++] = new Uint32List.view(new Uint32List(256).buffer);\n"
+ " list[index++] = new Int64List.view(new Int64List(256).buffer);\n"
+ " list[index++] = new Uint64List.view(new Uint64List(256).buffer);\n"
+ " list[index++] = new Float32List.view(new Float32List(256).buffer);\n"
+ " list[index++] = new Float64List.view(new Float64List(256).buffer);\n"
+
+ " list[index++] = new Int8List.view(new Int16List(256).buffer);\n"
+ " list[index++] = new Uint8List.view(new Uint16List(256).buffer);\n"
+ " list[index++] = new Int8List.view(new Int32List(256).buffer);\n"
+ " list[index++] = new Uint8List.view(new Uint32List(256).buffer);\n"
+ " list[index++] = new Int8List.view(new Int64List(256).buffer);\n"
+ " list[index++] = new Uint8List.view(new Uint64List(256).buffer);\n"
+ " list[index++] = new Int8List.view(new Float32List(256).buffer);\n"
+ " list[index++] = new Uint8List.view(new Float32List(256).buffer);\n"
+ " list[index++] = new Int8List.view(new Float64List(256).buffer);\n"
+ " list[index++] = new Uint8List.view(new Float64List(256).buffer);\n"
+
+ " list[index++] = new Int16List.view(new Int8List(256).buffer);\n"
+ " list[index++] = new Uint16List.view(new Uint8List(256).buffer);\n"
+ " list[index++] = new Int16List.view(new Int32List(256).buffer);\n"
+ " list[index++] = new Uint16List.view(new Uint32List(256).buffer);\n"
+ " list[index++] = new Int16List.view(new Int64List(256).buffer);\n"
+ " list[index++] = new Uint16List.view(new Uint64List(256).buffer);\n"
+ " list[index++] = new Int16List.view(new Float32List(256).buffer);\n"
+ " list[index++] = new Uint16List.view(new Float32List(256).buffer);\n"
+ " list[index++] = new Int16List.view(new Float64List(256).buffer);\n"
+ " list[index++] = new Uint16List.view(new Float64List(256).buffer);\n"
" return list;\n"
"}\n"
"getMultipleTypedDataViewList() {\n"
" var list = new List(10);\n"
" var index = 0;\n"
- " var data = new Uint8List(256);\n"
+ " var data = new Uint8List(256).buffer;\n"
" list[index++] = new Int8List.view(data);\n"
" list[index++] = new Uint8List.view(data);\n"
" list[index++] = new Int16List.view(data);\n"
« no previous file with comments | « runtime/vm/service_test.cc ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698