Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: sdk/lib/typed_data/typed_data.dart

Issue 138033002: Make VM TypedList not implement ByteBuffer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove expando, change test. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/typed_data/typed_data.dart
diff --git a/sdk/lib/typed_data/typed_data.dart b/sdk/lib/typed_data/typed_data.dart
index 9d37eb6830760eb3f83699c60121a9228a7be644..3aa7ce654f73220f9b647c9fc73dc02c655bbe4e 100644
--- a/sdk/lib/typed_data/typed_data.dart
+++ b/sdk/lib/typed_data/typed_data.dart
@@ -12,6 +12,10 @@ import 'dart:math' show Random;
* A sequence of bytes underlying a typed data object.
* Used to process large quantities of binary or numerical data
* more efficiently using a typed view.
+ *
+ * The `ByteBuffer` instances created by this library are the only ones
+ * that will work with the `view` constructors.
+ * Creating a class implementing `ByteBuffer` will not make it usable.
*/
abstract class ByteBuffer {
/**
@@ -19,6 +23,15 @@ abstract class ByteBuffer {
*/
int get lengthInBytes;
+ int get hashCode;
+
+ /**
+ * Is [other] a `ByteBuffer` holding the same memory as this.
+ *
+ * A `ByteBuffer` is only equal to another `ByteBuffer` that
+ * represents the same underlying memory.
+ */
+ bool operator==(Object other);
}
@@ -44,6 +57,10 @@ abstract class TypedData {
/**
* Returns the byte buffer associated with this object.
+ *
+ * The returned object represents the underlying memory.
+ * It may be the same object returned each time, or a new object representing
+ * the same memory.
*/
ByteBuffer get buffer;
}
@@ -54,8 +71,6 @@ abstract class TypedData {
* sequence of bytes.
*/
class Endianness {
- const Endianness._(this._littleEndian);
-
static const Endianness BIG_ENDIAN = const Endianness._(false);
static const Endianness LITTLE_ENDIAN = const Endianness._(true);
static final Endianness HOST_ENDIAN =
@@ -63,6 +78,8 @@ class Endianness {
LITTLE_ENDIAN : BIG_ENDIAN;
final bool _littleEndian;
+
+ const Endianness._(this._littleEndian);
}

Powered by Google App Engine
This is Rietveld 408576698