runtime/vm/dart_api_impl.cc - Issue 138033002: Make VM TypedList not implement ByteBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 138033002: Make VM TypedList not implement ByteBuffer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index 02cf5125698ae4a8372245e1c68895dff208071e..e1ee6ad5bda0d65669fc889a2110c1d56efc58cd 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -2597,7 +2597,7 @@ static Dart_Handle NewExternalByteData(

return ext_data;

}

Object& result = Object::Handle(isolate);

- result = GetByteDataConstructor(isolate, Symbols::ByteDataDotview(), 3);

+ result = GetByteDataConstructor(isolate, Symbols::ByteDataDot_view(), 3);

Lasse Reichstein Nielsen 2014/01/14 11:06:47 Would it be better to get the _ByteDataView constr

ASSERT(!result.IsNull());

ASSERT(result.IsFunction());

const Function& factory = Function::Cast(result);

« no previous file with comments | « runtime/lib/typed_data.dart ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »