Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1380323003: Subzero: With -asm-verbose, make the predecessor list more compact. (Closed)

Created:
5 years, 2 months ago by Jim Stichnoth
Modified:
5 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: With -asm-verbose, make the predecessor list more compact. Instead of a comment like this: # preds=.Lfv_update_nonbon$split___114___115_0,.Lfv_update_nonbon$split___138___115_1 remove some redundancy and make the comment like this: # preds=$split___114___115_0,$split___138___115_1 This makes it slightly easier to read, and less likely to exceed 80 columns. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=9a63babb7bbd61b944dc0bcbe94497fece15cedd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/IceCfgNode.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
5 years, 2 months ago (2015-10-02 16:48:12 UTC) #2
Karl
lgtm
5 years, 2 months ago (2015-10-05 17:56:01 UTC) #3
Jim Stichnoth
5 years, 2 months ago (2015-10-05 18:14:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a63babb7bbd61b944dc0bcbe94497fece15cedd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698