Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1380253004: Change scoped_ptr<FrameTreeNode> to FrameTreeNode* (Closed)

Created:
5 years, 2 months ago by ncarter (slow)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change scoped_ptr<FrameTreeNode> to FrameTreeNode* This fixes an issue with ~FrameTree() which would be problematic if scoped_ptr were made to have the null-before-delete semantics of libc++'s unique_ptr. BUG=535321 Committed: https://crrev.com/70b782d89203d62d8b4e7937615579a3fc04583b Cr-Commit-Position: refs/heads/master@{#352630}

Patch Set 1 #

Total comments: 2

Patch Set 2 : uppercase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M content/browser/frame_host/frame_tree.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 4 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ncarter (slow)
amistry, ptal
5 years, 2 months ago (2015-10-05 16:59:31 UTC) #2
nasko
Drive-by nit. https://codereview.chromium.org/1380253004/diff/1/content/browser/frame_host/frame_tree.h File content/browser/frame_host/frame_tree.h (right): https://codereview.chromium.org/1380253004/diff/1/content/browser/frame_host/frame_tree.h#newcode183 content/browser/frame_host/frame_tree.h:183: // This is an owned ptr to ...
5 years, 2 months ago (2015-10-05 17:19:31 UTC) #4
ncarter (slow)
https://codereview.chromium.org/1380253004/diff/1/content/browser/frame_host/frame_tree.h File content/browser/frame_host/frame_tree.h (right): https://codereview.chromium.org/1380253004/diff/1/content/browser/frame_host/frame_tree.h#newcode183 content/browser/frame_host/frame_tree.h:183: // This is an owned ptr to the root ...
5 years, 2 months ago (2015-10-05 17:23:22 UTC) #5
Anand Mistry (off Chromium)
LGTM Thanks.
5 years, 2 months ago (2015-10-06 04:30:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380253004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380253004/20001
5 years, 2 months ago (2015-10-06 16:36:27 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-06 17:37:18 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 17:38:42 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70b782d89203d62d8b4e7937615579a3fc04583b
Cr-Commit-Position: refs/heads/master@{#352630}

Powered by Google App Engine
This is Rietveld 408576698