Issue 138023007: Renamed :host to :ancestor and made :host to match only shadow host.

Issue 138023007: Renamed :host to :ancestor and made :host to match only shadow host. (Closed)

Created:
6 years, 11 months ago by tasak

Modified:
6 years, 11 months ago

Reviewers:
chrishtr, dglazkov

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Renamed :host to :ancestor and made :host to match only shadow host. BUG=334542 TEST=fast/dom/shadow/ancestor-pseudo-class.html,fast/dom/shadow/host-pseudo-class.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165172

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+173 lines, -158 lines)			Patch
A +	LayoutTests/fast/dom/shadow/ancestor-pseudo-class.html	View	21 chunks	+57 lines, -43 lines	0 comments	Download
A +	LayoutTests/fast/dom/shadow/ancestor-pseudo-class-expected.txt	View	1 chunk	+18 lines, -16 lines	1 comment	Download
M	LayoutTests/fast/dom/shadow/host-pseudo-class.html	View	5 chunks	+44 lines, -86 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/host-pseudo-class-expected.txt	View	1 chunk	+4 lines, -8 lines	0 comments	Download
M	Source/core/css/CSSGrammar.y	View	3 chunks	+25 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSSelector.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/css/CSSSelector.cpp	View	7 chunks	+10 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSTokenizer-in.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/css/SelectorChecker.cpp	View	3 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/138023007/1

6 years, 11 months ago (2014-01-15 18:50:49 UTC) #3

chrishtr

6 years, 11 months ago (2014-01-21 23:29:06 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/138023007/diff/1/LayoutTests/fast/dom/shadow/...
File LayoutTests/fast/dom/shadow/ancestor-pseudo-class-expected.txt (right):

https://codereview.chromium.org/138023007/diff/1/LayoutTests/fast/dom/shadow/...
LayoutTests/fast/dom/shadow/ancestor-pseudo-class-expected.txt:35: FAIL
backgroundColorOf('host') should be rgba(0, 0, 0, 0). Was rgb(0, 128, 0).
Are these failures intended? A refactoring CL I am working on now makes them
pass again. I hope my change fixes a real bug?

Expand Messages | Collapse Messages