Issue 138023004: Use local coordinates in TouchEditable interface

Issue 138023004: Use local coordinates in TouchEditable interface (Closed)

Created:
6 years, 11 months ago by mohsen

Modified:
6 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use local coordinates in TouchEditable interface In TouchEditable interface, almost all points are expected to be in local coordinates of the editable view, except GetBounds() which wrongly expects points in the parent view coordinates. Up to r244436, this was not a problem since editable views completely covered their parents and have the same coordinates with them. Fixing this situation to prevent similar problems in the future. BUG=334009 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245152

Patch Set 1 #

Patch Set 2 : Added TODO for switching to screen coordinates #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
M	content/browser/web_contents/touch_editable_impl_aura.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/base/touch/touch_editing_controller.h	View	1	3 chunks	+6 lines, -2 lines	0 comments	Download
M	ui/views/controls/textfield/textfield.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/138023004/120002

6 years, 11 months ago (2014-01-15 19:16:31 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=246829

6 years, 11 months ago (2014-01-16 00:19:43 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/138023004/120002

6 years, 11 months ago (2014-01-16 00:25:52 UTC) #5

Message was sent while issue was closed.

Change committed as 245152

Expand Messages | Collapse Messages