third_party/WebKit/Source/core/html/ImageDocument.cpp - Issue 1380163006: setLoadFinishTime on ImageResource for ImageDocument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/ImageDocument.cpp

Issue 1380163006: setLoadFinishTime on ImageResource for ImageDocument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unit test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/ImageDocument.cpp

diff --git a/third_party/WebKit/Source/core/html/ImageDocument.cpp b/third_party/WebKit/Source/core/html/ImageDocument.cpp

index 3776a2b571c4f70c532c55ca6c46c393b46e1b11..6a16b3077c5baefe5169745dd9695c29ec9df216 100644

--- a/third_party/WebKit/Source/core/html/ImageDocument.cpp

+++ b/third_party/WebKit/Source/core/html/ImageDocument.cpp

@@ -156,8 +156,10 @@ void ImageDocumentParser::finish()

{

if (!isStopped() && document()->imageElement() && document()->cachedImage()) {

ImageResource* cachedImage = document()->cachedImage();

+ DocumentLoader* loader = document()->loader();

+ cachedImage->setResponse(loader->response());

rune 2015/10/04 18:02:57 Moved setResponse() before finish() because that's

+ cachedImage->setLoadFinishTime(loader->timing().responseEnd());

cachedImage->finish();

- cachedImage->setResponse(document()->frame()->loader().documentLoader()->response());

// Report the natural image size in the page title, regardless of zoom level.

// At a zoom level of 1 the image is guaranteed to have an integer size.

« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »