Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1380153002: Fix for texture width or height are greater than 2^16 (Closed)

Created:
5 years, 2 months ago by joshua.litt
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix for texture width or height are greater than 2^16 BUG=skia:3467 TBR= Committed: https://skia.googlesource.com/skia/+/b90de31355f601498b6ad69af703de37e82cd894

Patch Set 1 #

Total comments: 2

Patch Set 2 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M src/gpu/GrTexture.cpp View 1 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
joshualitt
ptal
5 years, 2 months ago (2015-10-01 17:21:43 UTC) #2
robertphillips
https://codereview.chromium.org/1380153002/diff/1/src/gpu/GrTexture.cpp File src/gpu/GrTexture.cpp (right): https://codereview.chromium.org/1380153002/diff/1/src/gpu/GrTexture.cpp#newcode108 src/gpu/GrTexture.cpp:108: If we do this I propose we just always ...
5 years, 2 months ago (2015-10-01 17:51:01 UTC) #3
bsalomon
https://codereview.chromium.org/1380153002/diff/1/src/gpu/GrTexture.cpp File src/gpu/GrTexture.cpp (right): https://codereview.chromium.org/1380153002/diff/1/src/gpu/GrTexture.cpp#newcode108 src/gpu/GrTexture.cpp:108: On 2015/10/01 17:51:01, robertphillips wrote: > If we do ...
5 years, 2 months ago (2015-10-01 18:05:44 UTC) #4
joshualitt
On 2015/10/01 18:05:44, bsalomon wrote: > https://codereview.chromium.org/1380153002/diff/1/src/gpu/GrTexture.cpp > File src/gpu/GrTexture.cpp (right): > > https://codereview.chromium.org/1380153002/diff/1/src/gpu/GrTexture.cpp#newcode108 > ...
5 years, 2 months ago (2015-10-01 18:18:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380153002/20001
5 years, 2 months ago (2015-10-01 18:47:49 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 18:54:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b90de31355f601498b6ad69af703de37e82cd894

Powered by Google App Engine
This is Rietveld 408576698