Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: include/core/SkCanvas.h

Issue 138013009: Culling API (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Rebased, fCullOffsetStack decl -> unconditional Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/core/SkCanvas.h
diff --git a/include/core/SkCanvas.h b/include/core/SkCanvas.h
index e639212e384b0f58dda00b3e8086cbe03a059688..bceedba3f3a9a59dbac1239a6bc0ac08494c139c 100644
--- a/include/core/SkCanvas.h
+++ b/include/core/SkCanvas.h
@@ -935,7 +935,26 @@ public:
// do nothing. Subclasses may do something
}
+ /**
+ * This call asserts that subsequent draw operations (up to the matching popCull() call)
+ * are fully contained within the given bounding box. The assertion is not enforced,
+ * but the information might be used to quick-reject command blocks, so an incorrect
+ * bounding box may result in incomplete rendering.
+ */
+ void pushCull(const SkRect& cullRect) {
robertphillips 2014/02/25 15:58:41 ++fCullCount?
+ fCullCount += 1;
+ this->onPushCull(cullRect);
+ }
+ /**
+ * Terminates the current culling block, and restores the previous one (if any).
+ */
+ void popCull() {
robertphillips 2014/02/25 15:58:41 Maybe and "SkASSERT(fCullCount > 0);" to assist de
+ if (fCullCount > 0) {
robertphillips 2014/02/25 15:58:41 --fCullCount?
+ fCullCount -= 1;
+ this->onPopCull();
+ }
+ }
//////////////////////////////////////////////////////////////////////////
/** Get the current bounder object.
@@ -1101,6 +1120,9 @@ protected:
// can perform copy-on-write or invalidate any cached images
void predrawNotify();
+ virtual void onPushCull(const SkRect& cullRect);
+ virtual void onPopCull();
+
private:
class MCRec;
@@ -1113,6 +1135,7 @@ private:
SkBounder* fBounder;
int fSaveLayerCount; // number of successful saveLayer calls
+ int fCullCount; // number of active culls
SkMetaData* fMetaData;

Powered by Google App Engine
This is Rietveld 408576698