Clean-up: Renames gfx::Font's methods and removes its obsolete methods.

Clean-up: Renames gfx::Font's methods and removes its obsolete methods.

Applies the same renaming as http://crrev.com/142523003 and also removes obsolete methods.

Renamed methods:
- DeriveFont(size_delta, style) => Derive(size_delta, style)

Removed methods:
- DeriveFont(size_delta)
- GetAverageCharacterWidth()
  # Use GetExpectedTextWidth(1) instead.
- GetStringWidth(text)
  # Use gfx::GetStringWidth(text, font_list) instead.

BUG=265485
TEST=Run ui_unittests, views_unittests.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251028

[Yuki, 2014-02-10 08:53:58]

Could you guys review this CL?  Thanks.

[Alexei Svitkine (slow), 2014-02-10 15:37:54]

Change looks good, but if you're removing GetAverageCharacterWidth() because
it's not used anywhere, can you also remove its implementations from the various
PlatformFont* classes?

[Yuki, 2014-02-11 11:53:22]

On 2014/02/10 15:37:54, Alexei Svitkine wrote:
> Change looks good, but if you're removing GetAverageCharacterWidth() because
> it's not used anywhere, can you also remove its implementations from the
various
> PlatformFont* classes?

Yes.  Removed unused methods in PlatformFont.

[Alexei Svitkine (slow), 2014-02-11 14:01:21]

Change looks good, however now that I think about it, I think it would be better
to make this two CLs. Move the GetAverageCharacterWidth() removal to a separate
CL. (That way, if it ever needs to come back, it would be easier for someone to
just restore that part.)

[Yuki, 2014-02-12 03:07:22]

On 2014/02/11 14:01:21, Alexei Svitkine wrote:
> Change looks good, however now that I think about it, I think it would be
better
> to make this two CLs. Move the GetAverageCharacterWidth() removal to a
separate
> CL. (That way, if it ever needs to come back, it would be easier for someone
to
> just restore that part.)

It's not recommended that the client code directly uses gfx::Font, the client
code should use gfx::FontList instead.  So I don't think removing these methods
at a time affects much.  FontList::GetAverageCharacterWidth() had already been
removed.  In addition, GetExpectedTextWidth(1) is almost equivalent to
GetAverageCharacterWidth().  So don't worry too much.

[Alexei Svitkine (slow), 2014-02-12 15:30:27]

Fair enough, LGTM.

However, can you add a BUG= to the CL description and change it to mention the
names of the methods that you're removing from the Font API?

Thanks!

[msw, 2014-02-12 18:17:09]

LGTM with ditto to Alexei's remaining CL description comments.

[Yuki, 2014-02-13 04:28:21]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2014-02-13 04:28:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/138013004/460002

[commit-bot: I haz the power, 2014-02-13 15:41:53]

Change committed as 251028