Issue 1380103005: Compute Outline.kind/libraryName actually.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1380103005: Compute Outline.kind/libraryName actually. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Compute Outline.kind/libraryName actually. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/24279 Committed: https://github.com/dart-lang/sdk/commit/03e379de7a8933748fc4ce88bdf1cdfdc61e25e1

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -16 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	2 chunks	+12 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/operation/operation_analysis.dart	View	7 chunks	+39 lines, -13 lines	0 comments	Download
M	pkg/analysis_server/test/analysis/notification_outline_test.dart	View	3 chunks	+32 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1380103005/diff/1/pkg/analysis_server/test/analysis/notification_outline_test.dart File pkg/analysis_server/test/analysis/notification_outline_test.dart (right): https://codereview.chromium.org/1380103005/diff/1/pkg/analysis_server/test/analysis/notification_outline_test.dart#newcode318 pkg/analysis_server/test/analysis/notification_outline_test.dart:318: test_libraryName_hasLibraryDirective() async { Perhaps add a test for ...

5 years, 2 months ago (2015-10-01 20:01:16 UTC) #2

scheglov

5 years, 2 months ago (2015-10-01 20:09:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
03e379de7a8933748fc4ce88bdf1cdfdc61e25e1 (presubmit successful).

Expand Messages | Collapse Messages