apply_issue: 89 ret code on network/Rietveld failures.

apply_issue: 89 ret code on network/Rietveld failures.

This would allow bot_update to differentiate between patch download and
aplication failures.

R=phajdan.jr@chromium.org,sergiyb@chromium.org
BUG=537417
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296983

[tandrii(chromium), 2015-10-02 11:34:58]

PTAL

companion CL is https://codereview.chromium.org/1382203002

[Sergiy Byelozyorov, 2015-10-02 11:49:54]

https://codereview.chromium.org/1380093003/diff/1/apply_issue.py
File apply_issue.py (right):

https://codereview.chromium.org/1380093003/diff/1/apply_issue.py#newcode214
apply_issue.py:214: return 89
Ah.. since this is not in bot_update, I'd use next available code in this code,
which is 2.

[tandrii(chromium), 2015-10-02 11:53:53]

https://codereview.chromium.org/1380093003/diff/1/apply_issue.py
File apply_issue.py (right):

https://codereview.chromium.org/1380093003/diff/1/apply_issue.py#newcode214
apply_issue.py:214: return 89
On 2015/10/02 11:49:54, Sergiy Byelozyorov wrote:
> Ah.. since this is not in bot_update, I'd use next available code in this
code,
> which is 2.
OK, 3 because 2 is from argparse:
https://hg.python.org/cpython/file/2.7/Lib/argparse.py#l2374

[tandrii(chromium), 2015-10-02 12:38:12]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-02 12:38:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1380093003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1380093003/20001

[Sergiy Byelozyorov, 2015-10-02 12:39:36]

lgtm

[commit-bot: I haz the power, 2015-10-02 12:40:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-02 12:40:19]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2015-10-02 13:02:14]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2015-10-02 13:02:15]

The patchset sent to the CQ was uploaded after l-g-t-m from sergiyb@chromium.org
Link to the patchset: https://codereview.chromium.org/1380093003/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2015-10-02 13:02:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1380093003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1380093003/40001

[commit-bot: I haz the power, 2015-10-02 13:07:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-02 13:07:10]

Try jobs failed on following builders:
  depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)

[jochen (gone - plz use gerrit), 2015-10-02 13:58:13]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-10-02 13:58:14]

lgtm

[tandrii(chromium), 2015-10-02 14:02:35]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2015-10-02 14:02:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1380093003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1380093003/40001

[commit-bot: I haz the power, 2015-10-02 14:05:15]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296983