Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: Source/bindings/tests/results/V8TestInterface.cpp

Issue 138003013: Remove unnecessary maybeDOMWrapper from indexed/named property getters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 631
632 static void namedPropertyGetter(v8::Local<v8::String> name, const v8::PropertyCa llbackInfo<v8::Value>& info) 632 static void namedPropertyGetter(v8::Local<v8::String> name, const v8::PropertyCa llbackInfo<v8::Value>& info)
633 { 633 {
634 if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty()) 634 if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
635 return; 635 return;
636 if (info.Holder()->HasRealNamedCallbackProperty(name)) 636 if (info.Holder()->HasRealNamedCallbackProperty(name))
637 return; 637 return;
638 if (info.Holder()->HasRealNamedProperty(name)) 638 if (info.Holder()->HasRealNamedProperty(name))
639 return; 639 return;
640 640
641 ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));
642 TestInterface* collection = V8TestInterface::toNative(info.Holder()); 641 TestInterface* collection = V8TestInterface::toNative(info.Holder());
643 AtomicString propertyName = toCoreAtomicString(name); 642 AtomicString propertyName = toCoreAtomicString(name);
644 bool element0Enabled = false; 643 bool element0Enabled = false;
645 RefPtr<Node> element0; 644 RefPtr<Node> element0;
646 bool element1Enabled = false; 645 bool element1Enabled = false;
647 RefPtr<NodeList> element1; 646 RefPtr<NodeList> element1;
648 collection->getItem(propertyName, element0Enabled, element0, element1Enabled , element1); 647 collection->getItem(propertyName, element0Enabled, element0, element1Enabled , element1);
649 if (element0Enabled) { 648 if (element0Enabled) {
650 v8SetReturnValueFast(info, element0.release(), collection); 649 v8SetReturnValueFast(info, element0.release(), collection);
651 return; 650 return;
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
899 } 898 }
900 899
901 template<> 900 template<>
902 v8::Handle<v8::Value> toV8NoInline(TestInterface* impl, v8::Handle<v8::Object> c reationContext, v8::Isolate* isolate) 901 v8::Handle<v8::Value> toV8NoInline(TestInterface* impl, v8::Handle<v8::Object> c reationContext, v8::Isolate* isolate)
903 { 902 {
904 return toV8(impl, creationContext, isolate); 903 return toV8(impl, creationContext, isolate);
905 } 904 }
906 905
907 } // namespace WebCore 906 } // namespace WebCore
908 #endif // ENABLE(Condition1) || ENABLE(Condition2) 907 #endif // ENABLE(Condition1) || ENABLE(Condition2)
OLDNEW
« no previous file with comments | « Source/bindings/tests/results/V8TestEventTarget.cpp ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698