Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 1380023005: benchmark.mojo: add time_between measurement type. (Closed)

Created:
5 years, 2 months ago by ppi
Modified:
5 years, 2 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

benchmark.mojo: Add time_between measurement type. This allows us to define benchmarks that are in control of their time origin. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9d5995ef18998fc32d157acdb95981918a1e8171

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -58 lines) Patch
M apps/benchmark/README.md View 1 1 chunk +13 lines, -5 lines 0 comments Download
M apps/benchmark/measurements.h View 2 chunks +11 lines, -3 lines 0 comments Download
M apps/benchmark/measurements.cc View 3 chunks +34 lines, -7 lines 0 comments Download
M apps/benchmark/measurements_unittest.cc View 4 chunks +101 lines, -38 lines 0 comments Download
M apps/benchmark/run_args.cc View 1 chunk +27 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ppi
Hi Ben, ptal.
5 years, 2 months ago (2015-10-01 09:48:43 UTC) #1
qsr
LGTM with nits. https://codereview.chromium.org/1380023005/diff/1/apps/benchmark/measurements.cc File apps/benchmark/measurements.cc (right): https://codereview.chromium.org/1380023005/diff/1/apps/benchmark/measurements.cc#newcode57 apps/benchmark/measurements.cc:57: base::TimeTicks result; What about initializing this ...
5 years, 2 months ago (2015-10-01 10:52:45 UTC) #2
ppi
https://codereview.chromium.org/1380023005/diff/1/apps/benchmark/measurements.cc File apps/benchmark/measurements.cc (right): https://codereview.chromium.org/1380023005/diff/1/apps/benchmark/measurements.cc#newcode57 apps/benchmark/measurements.cc:57: base::TimeTicks result; On 2015/10/01 10:52:45, qsr wrote: > What ...
5 years, 2 months ago (2015-10-01 12:42:48 UTC) #3
ppi
5 years, 2 months ago (2015-10-01 12:48:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9d5995ef18998fc32d157acdb95981918a1e8171 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698