Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1380023002: Revert of Don't choose a background process when choosing a process for starting a Service Worker. (Closed)

Created:
5 years, 2 months ago by horo
Modified:
5 years, 2 months ago
Reviewers:
kinuko
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, creis+watch_chromium.org, tzik, nasko+codewatch_chromium.org, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org, Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't choose a background process when choosing a process for starting a Service Worker. (patchset #2 id:20001 of https://codereview.chromium.org/1373853003/ ) Reason for revert: - This patch will increase memory pressure to launch a new SW process. - More reasonable patch (crrev.com/351714) landed. Original issue's description: > Don't choose a background process when choosing a process for starting a Service Worker. > > This is a quick fix for https://crbug.com/531345. > We need to revisit the behavior of ServiceWorker and the timer suspension of background processes which was intoruced by https://codereview.chromium.org/1133143003. > > BUG=531345 > > Committed: https://crrev.com/3ddd919b0f5550377e178ba6d4aa5256701d53ff > Cr-Commit-Position: refs/heads/master@{#351530} TBR=kinuko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=531345 Committed: https://crrev.com/fc61da261fddeb5e9cc65bc93b3620258a596dce Cr-Commit-Position: refs/heads/master@{#351720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_process_manager.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
horo
Created Revert of Don't choose a background process when choosing a process for starting a ...
5 years, 2 months ago (2015-10-01 03:43:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380023002/1
5 years, 2 months ago (2015-10-01 03:43:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 03:44:58 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 03:45:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc61da261fddeb5e9cc65bc93b3620258a596dce
Cr-Commit-Position: refs/heads/master@{#351720}

Powered by Google App Engine
This is Rietveld 408576698