Update the R= line with the actual list of reviewers that approved the CL.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 import json
@@ skipping 629 matching lines @@
     self.has_patchset = False
 
   def GetMostRecentPatchset(self, issue):
     return self.RpcServer().get_issue_properties(
         int(issue), False)['patchsets'][-1]
 
   def GetPatchSetDiff(self, issue, patchset):
     return self.RpcServer().get(
         '/download/issue%s_%s.diff' % (issue, patchset))
 
+  def GetActualReviewers(self, issue):

[Dirk Pranke, 2013/04/09 00:15:51]

should this be GetRealReviewers to match?

[M-A Ruel, 2013/04/11 01:11:28]

GetApprovingReviewers()

+    return get_real_reviewers(
+        self.RpcServer().get_issue_properties(int(issue), False))
+
   def SetIssue(self, issue):
     """Set this branch's issue.  If issue=0, clears the issue."""
     if issue:
       RunGit(['config', self._IssueSetting(), str(issue)])
       if self.rietveld_server:
         RunGit(['config', self._RietveldServer(), self.rietveld_server])
     else:
       RunGit(['config', '--unset', self._IssueSetting()])
       self.SetPatchset(0)
     self.has_issue = False
@@ skipping 208 matching lines @@
   def get_reviewers(self):
     """Retrieves the list of reviewers."""
     regexp = re.compile(self.R_LINE, re.MULTILINE)
     reviewers = sum(
         (i.group(2).split(',') for i in regexp.finditer(self.description)),
         [])
     reviewers = (i.strip() for i in reviewers)
     return sorted(i for i in reviewers if i)
 
 
+def get_real_reviewers(props):
+  """Retrieves the reviewers that approved a cL from the issue properties with

[Dirk Pranke, 2013/04/09 00:15:51]

nit: "CL", not "cL".

I wonder if this should be "get_approving_reviewers" or something instead of the
"real" reviewers, since "real" is potentially confusing.

[M-A Ruel, 2013/04/11 01:11:28]

Done.

+  messages.
+
+  Note that the list may contain reviewers that are not committer, thus are not
+  considered by the CQ.
+  """
+  return sorted(
+      set(
+        message['sender']
+        for message in props['messages']
+        if message['approval'] and message['sender'] in props['reviewers']
+      )
+  )
+
+
 def FindCodereviewSettingsFile(filename='codereview.settings'):
   """Finds the given file starting in the cwd and going up.
 
   Only looks up to the top of the repository unless an
   'inherit-review-settings-ok' file exists in the root of the repository.
   """
   inherit_ok_file = 'inherit-review-settings-ok'
   cwd = os.getcwd()
   root = os.path.abspath(RunGit(['rev-parse', '--show-cdup']).strip())
   if os.path.isfile(os.path.join(root, inherit_ok_file)):
@@ skipping 570 matching lines @@
     change_desc = ChangeDescription(cl.GetDescription())
 
   if not change_desc.description:
     if not cl.GetIssue() and options.bypass_hooks:
       change_desc = ChangeDescription(CreateDescriptionFromLog([base_branch]))
     else:
       print 'No description set.'
       print 'Visit %s/edit to set it.' % (cl.GetIssueURL())
       return 1
 
+  if cl.GetIssue():
+    actual_reviewers = ','.join(cl.GetActualReviewers(cl.GetIssue()))
+    change_desc.update_reviewers(actual_reviewers)
+
   # Keep a separate copy for the commit message.
   commit_desc = ChangeDescription(change_desc.description)
   if cl.GetIssue():
     commit_desc.append_line('Review URL: %s' % cl.GetIssueURL())
   if options.contributor:
     commit_desc.append_line('Patch from %s.' % options.contributor)
 
   print 'Description:', repr(commit_desc.description)
 
   branches = [base_branch, cl.GetBranchRef()]
@@ skipping 470 matching lines @@
              'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
   # Not a known command. Default to help.
   GenUsage(parser, 'help')
   return CMDhelp(parser, argv)
 
 
 if __name__ == '__main__':
   fix_encoding.fix_encoding()
   sys.exit(main(sys.argv[1:]))