Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: components/undo/bookmark_undo_service.h

Issue 1379983002: Supporting undoing bookmark deletion without creating new ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address some more feedback Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/undo/bookmark_renumber_observer.h ('k') | components/undo/bookmark_undo_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_UNDO_BOOKMARK_UNDO_SERVICE_H_ 5 #ifndef COMPONENTS_UNDO_BOOKMARK_UNDO_SERVICE_H_
6 #define COMPONENTS_UNDO_BOOKMARK_UNDO_SERVICE_H_ 6 #define COMPONENTS_UNDO_BOOKMARK_UNDO_SERVICE_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/scoped_observer.h" 10 #include "base/scoped_observer.h"
11 #include "components/bookmarks/browser/base_bookmark_model_observer.h" 11 #include "components/bookmarks/browser/base_bookmark_model_observer.h"
12 #include "components/bookmarks/browser/bookmark_node_data.h" 12 #include "components/bookmarks/browser/bookmark_node_data.h"
13 #include "components/bookmarks/browser/bookmark_undo_delegate.h"
13 #include "components/keyed_service/core/keyed_service.h" 14 #include "components/keyed_service/core/keyed_service.h"
14 #include "components/undo/bookmark_renumber_observer.h"
15 #include "components/undo/undo_manager.h" 15 #include "components/undo/undo_manager.h"
16 16
17 namespace bookmarks { 17 namespace bookmarks {
18 class BookmarkModel; 18 class BookmarkModel;
19 class BookmarkModelObserver; 19 class BookmarkModelObserver;
20 } 20 }
21 21
22 // BookmarkUndoService -------------------------------------------------------- 22 // BookmarkUndoService --------------------------------------------------------
23 23
24 // BookmarkUndoService is owned by the profile, and is responsible for observing 24 // BookmarkUndoService is owned by the profile, and is responsible for observing
25 // BookmarkModel changes in order to provide an undo for those changes. 25 // BookmarkModel changes in order to provide an undo for those changes.
26 class BookmarkUndoService : public bookmarks::BaseBookmarkModelObserver, 26 class BookmarkUndoService : public bookmarks::BaseBookmarkModelObserver,
27 public KeyedService, 27 public bookmarks::BookmarkUndoDelegate,
28 public BookmarkRenumberObserver { 28 public KeyedService {
29 public: 29 public:
30 BookmarkUndoService(); 30 BookmarkUndoService();
31 ~BookmarkUndoService() override; 31 ~BookmarkUndoService() override;
32 32
33 // Starts the BookmarkUndoService and register it as a BookmarkModelObserver. 33 // Starts the BookmarkUndoService and register it as a BookmarkModelObserver.
34 // Calling this method is optional, but the service will be inactive until it 34 // Calling this method is optional, but the service will be inactive until it
35 // is called. 35 // is called.
36 void Start(bookmarks::BookmarkModel* model); 36 void Start(bookmarks::BookmarkModel* model);
37 37
38 UndoManager* undo_manager() { return &undo_manager_; } 38 UndoManager* undo_manager() { return &undo_manager_; }
39 39
40 // KeyedService: 40 // KeyedService:
41 void Shutdown() override; 41 void Shutdown() override;
42 42
43 private: 43 private:
44 // bookmarks::BaseBookmarkModelObserver: 44 // bookmarks::BaseBookmarkModelObserver:
45 void BookmarkModelChanged() override {} 45 void BookmarkModelChanged() override {}
46 void BookmarkModelLoaded(bookmarks::BookmarkModel* model, 46 void BookmarkModelLoaded(bookmarks::BookmarkModel* model,
47 bool ids_reassigned) override; 47 bool ids_reassigned) override;
48 void BookmarkModelBeingDeleted(bookmarks::BookmarkModel* model) override; 48 void BookmarkModelBeingDeleted(bookmarks::BookmarkModel* model) override;
49 void BookmarkNodeMoved(bookmarks::BookmarkModel* model, 49 void BookmarkNodeMoved(bookmarks::BookmarkModel* model,
50 const bookmarks::BookmarkNode* old_parent, 50 const bookmarks::BookmarkNode* old_parent,
51 int old_index, 51 int old_index,
52 const bookmarks::BookmarkNode* new_parent, 52 const bookmarks::BookmarkNode* new_parent,
53 int new_index) override; 53 int new_index) override;
54 void BookmarkNodeAdded(bookmarks::BookmarkModel* model, 54 void BookmarkNodeAdded(bookmarks::BookmarkModel* model,
55 const bookmarks::BookmarkNode* parent, 55 const bookmarks::BookmarkNode* parent,
56 int index) override; 56 int index) override;
57 void OnWillRemoveBookmarks(bookmarks::BookmarkModel* model,
58 const bookmarks::BookmarkNode* parent,
59 int old_index,
60 const bookmarks::BookmarkNode* node) override;
61 void OnWillRemoveAllUserBookmarks(bookmarks::BookmarkModel* model) override;
62 void OnWillChangeBookmarkNode(bookmarks::BookmarkModel* model, 57 void OnWillChangeBookmarkNode(bookmarks::BookmarkModel* model,
63 const bookmarks::BookmarkNode* node) override; 58 const bookmarks::BookmarkNode* node) override;
64 void OnWillReorderBookmarkNode(bookmarks::BookmarkModel* model, 59 void OnWillReorderBookmarkNode(bookmarks::BookmarkModel* model,
65 const bookmarks::BookmarkNode* node) override; 60 const bookmarks::BookmarkNode* node) override;
66 void GroupedBookmarkChangesBeginning( 61 void GroupedBookmarkChangesBeginning(
67 bookmarks::BookmarkModel* model) override; 62 bookmarks::BookmarkModel* model) override;
68 void GroupedBookmarkChangesEnded(bookmarks::BookmarkModel* model) override; 63 void GroupedBookmarkChangesEnded(bookmarks::BookmarkModel* model) override;
69 64
70 // BookmarkRenumberObserver: 65 // bookmarks::BookmarkUndoDelegate:
71 void OnBookmarkRenumbered(int64 old_id, int64 new_id) override; 66 void SetUndoProvider(bookmarks::BookmarkUndoProvider* undo_provider) override;
67 void OnBookmarkNodeRemoved(bookmarks::BookmarkModel* model,
68 const bookmarks::BookmarkNode* parent,
69 int index,
70 scoped_ptr<bookmarks::BookmarkNode> node) override;
72 71
72 bookmarks::BookmarkModel* model_;
73 bookmarks::BookmarkUndoProvider* undo_provider_;
73 UndoManager undo_manager_; 74 UndoManager undo_manager_;
74 ScopedObserver<bookmarks::BookmarkModel, bookmarks::BookmarkModelObserver> 75 ScopedObserver<bookmarks::BookmarkModel, bookmarks::BookmarkModelObserver>
75 scoped_observer_; 76 scoped_observer_;
76 77
77 DISALLOW_COPY_AND_ASSIGN(BookmarkUndoService); 78 DISALLOW_COPY_AND_ASSIGN(BookmarkUndoService);
78 }; 79 };
79 80
80 #endif // COMPONENTS_UNDO_BOOKMARK_UNDO_SERVICE_H_ 81 #endif // COMPONENTS_UNDO_BOOKMARK_UNDO_SERVICE_H_
OLDNEW
« no previous file with comments | « components/undo/bookmark_renumber_observer.h ('k') | components/undo/bookmark_undo_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698