Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Unified Diff: src/compiler/interpreter-assembler.cc

Issue 1379933003: Revert of [Interpreter] Add CallRuntime support to the interpreter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/interpreter-assembler.h ('k') | src/ia32/builtins-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/interpreter-assembler.cc
diff --git a/src/compiler/interpreter-assembler.cc b/src/compiler/interpreter-assembler.cc
index 5d4f9272c762cf6c53d635982b46a0ec2c12879d..3f5cf9a71eb048182da1cc5675f65bccc8520dde 100644
--- a/src/compiler/interpreter-assembler.cc
+++ b/src/compiler/interpreter-assembler.cc
@@ -314,30 +314,13 @@
}
-Node* InterpreterAssembler::CallN(CallDescriptor* descriptor,
- Node* code_target,
- Node** args) {
- Node* stack_pointer_before_call = nullptr;
- if (FLAG_debug_code) {
- stack_pointer_before_call = raw_assembler_->LoadStackPointer();
- }
- Node* return_val = raw_assembler_->CallN(descriptor, code_target, args);
- if (FLAG_debug_code) {
- Node* stack_pointer_after_call = raw_assembler_->LoadStackPointer();
- AbortIfWordNotEqual(stack_pointer_before_call, stack_pointer_after_call,
- kUnexpectedStackPointer);
- }
- return return_val;
-}
-
-
Node* InterpreterAssembler::CallJS(Node* function, Node* first_arg,
Node* arg_count) {
- Callable callable = CodeFactory::InterpreterPushArgsAndCall(isolate());
+ Callable builtin = CodeFactory::PushArgsAndCall(isolate());
CallDescriptor* descriptor = Linkage::GetStubCallDescriptor(
- isolate(), zone(), callable.descriptor(), 0, CallDescriptor::kNoFlags);
-
- Node* code_target = HeapConstant(callable.code());
+ isolate(), zone(), builtin.descriptor(), 0, CallDescriptor::kNoFlags);
+
+ Node* code_target = HeapConstant(builtin.code());
Node** args = zone()->NewArray<Node*>(4);
args[0] = arg_count;
@@ -345,7 +328,7 @@
args[2] = function;
args[3] = ContextTaggedPointer();
- return CallN(descriptor, code_target, args);
+ return raw_assembler_->CallN(descriptor, code_target, args);
}
@@ -353,7 +336,7 @@
Node* target, Node** args) {
CallDescriptor* call_descriptor = Linkage::GetStubCallDescriptor(
isolate(), zone(), descriptor, 0, CallDescriptor::kNoFlags);
- return CallN(call_descriptor, target, args);
+ return raw_assembler_->CallN(call_descriptor, target, args);
}
@@ -381,33 +364,6 @@
args[4] = arg5;
args[5] = ContextTaggedPointer();
return CallIC(descriptor, target, args);
-}
-
-
-Node* InterpreterAssembler::CallRuntime(Node* function_id, Node* first_arg,
- Node* arg_count) {
- Callable callable = CodeFactory::InterpreterCEntry(isolate());
- CallDescriptor* descriptor = Linkage::GetStubCallDescriptor(
- isolate(), zone(), callable.descriptor(), 0, CallDescriptor::kNoFlags);
-
- Node* code_target = HeapConstant(callable.code());
-
- // Get the function entry from the function id.
- Node* function_table = raw_assembler_->ExternalConstant(
- ExternalReference::runtime_function_table_address(isolate()));
- Node* function_offset = raw_assembler_->Int32Mul(
- function_id, Int32Constant(sizeof(Runtime::Function)));
- Node* function = IntPtrAdd(function_table, function_offset);
- Node* function_entry = raw_assembler_->Load(
- kMachPtr, function, Int32Constant(offsetof(Runtime::Function, entry)));
-
- Node** args = zone()->NewArray<Node*>(4);
- args[0] = arg_count;
- args[1] = first_arg;
- args[2] = function_entry;
- args[3] = ContextTaggedPointer();
-
- return CallN(descriptor, code_target, args);
}
@@ -508,19 +464,6 @@
}
-void InterpreterAssembler::AbortIfWordNotEqual(
- Node* lhs, Node* rhs, BailoutReason bailout_reason) {
- RawMachineAssembler::Label match, no_match;
- Node* condition = raw_assembler_->WordEqual(lhs, rhs);
- raw_assembler_->Branch(condition, &match, &no_match);
- raw_assembler_->Bind(&no_match);
- Node* abort_id = SmiTag(Int32Constant(bailout_reason));
- CallRuntime(Runtime::kAbort, abort_id);
- Return();
- raw_assembler_->Bind(&match);
-}
-
-
void InterpreterAssembler::AddEndInput(Node* input) {
DCHECK_NOT_NULL(input);
end_nodes_.push_back(input);
« no previous file with comments | « src/compiler/interpreter-assembler.h ('k') | src/ia32/builtins-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698