Add a11y on-screen keyboard to accessibility menu on system tray.

Add a11y on-screen keyboard to accessibility menu on system tray.

BUG=340760
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249033

[kevers, 2014-02-04 19:45:21]

Hi Daniel,

Can you please take a look at this CL.

[Daniel Erat, 2014-02-04 22:05:19]

https://codereview.chromium.org/137993021/diff/50001/ash/metrics/user_metrics...
File ash/metrics/user_metrics_recorder.cc (right):

https://codereview.chromium.org/137993021/diff/50001/ash/metrics/user_metrics...
ash/metrics/user_metrics_recorder.cc:231: case
ash::UMA_STATUS_AREA_DISABLE_VIRTUAL_KEYBOARD:
nit: please keep this list alphabetized (this should come before
ash::UMA_STATUS_AREA_DISABLE_WIFI)

https://codereview.chromium.org/137993021/diff/50001/ash/metrics/user_metrics...
ash/metrics/user_metrics_recorder.cc:267: case
ash::UMA_STATUS_AREA_ENABLE_VIRTUAL_KEYBOARD:
same here

https://codereview.chromium.org/137993021/diff/50001/ash/system/tray_accessib...
File ash/system/tray_accessibility.cc (right):

https://codereview.chromium.org/137993021/diff/50001/ash/system/tray_accessib...
ash/system/tray_accessibility.cc:277:
Shell::GetInstance()->metrics()->RecordUserMetricsAction(
this line is indented four spaces further than it should be

https://codereview.chromium.org/137993021/diff/50001/chrome/browser/chromeos/...
File chrome/browser/chromeos/system/tray_accessibility_browsertest.cc (right):

https://codereview.chromium.org/137993021/diff/50001/chrome/browser/chromeos/...
chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:172:
EXPECT_TRUE(button);
if OnViewClicked() will segfault if passed a NULL pointer, it would be better to
use ASSERT_TRUE(button) here (and in other similar methods). (if possible; i
always forget the rules for when you can use EXPECT_TRUE vs. ASSERT_TRUE in
method calls)

https://codereview.chromium.org/137993021/diff/50001/chrome/browser/chromeos/...
chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:372: 
delete this extra blank line

[kevers, 2014-02-04 22:37:56]

https://codereview.chromium.org/137993021/diff/50001/ash/metrics/user_metrics...
File ash/metrics/user_metrics_recorder.cc (right):

https://codereview.chromium.org/137993021/diff/50001/ash/metrics/user_metrics...
ash/metrics/user_metrics_recorder.cc:231: case
ash::UMA_STATUS_AREA_DISABLE_VIRTUAL_KEYBOARD:
On 2014/02/04 22:05:19, Daniel Erat wrote:
> nit: please keep this list alphabetized (this should come before
> ash::UMA_STATUS_AREA_DISABLE_WIFI)

Done.

https://codereview.chromium.org/137993021/diff/50001/ash/metrics/user_metrics...
ash/metrics/user_metrics_recorder.cc:267: case
ash::UMA_STATUS_AREA_ENABLE_VIRTUAL_KEYBOARD:
On 2014/02/04 22:05:19, Daniel Erat wrote:
> same here

Done.

https://codereview.chromium.org/137993021/diff/50001/ash/system/tray_accessib...
File ash/system/tray_accessibility.cc (right):

https://codereview.chromium.org/137993021/diff/50001/ash/system/tray_accessib...
ash/system/tray_accessibility.cc:277:
Shell::GetInstance()->metrics()->RecordUserMetricsAction(
On 2014/02/04 22:05:19, Daniel Erat wrote:
> this line is indented four spaces further than it should be

Fixed.

https://codereview.chromium.org/137993021/diff/50001/chrome/browser/chromeos/...
File chrome/browser/chromeos/system/tray_accessibility_browsertest.cc (right):

https://codereview.chromium.org/137993021/diff/50001/chrome/browser/chromeos/...
chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:172:
EXPECT_TRUE(button);
On 2014/02/04 22:05:19, Daniel Erat wrote:
> if OnViewClicked() will segfault if passed a NULL pointer, it would be better
to
> use ASSERT_TRUE(button) here (and in other similar methods). (if possible; i
> always forget the rules for when you can use EXPECT_TRUE vs. ASSERT_TRUE in
> method calls)

Switched to ASSERT_TRUE.

https://codereview.chromium.org/137993021/diff/50001/chrome/browser/chromeos/...
chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:372: 
On 2014/02/04 22:05:19, Daniel Erat wrote:
> delete this extra blank line

Done.

[Daniel Erat, 2014-02-04 22:54:40]

lgtm

[kevers, 2014-02-05 14:22:02]

The CQ bit was checked by kevers@chromium.org

[commit-bot: I haz the power, 2014-02-05 14:25:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/137993021/110001

[commit-bot: I haz the power, 2014-02-05 17:18:10]

Change committed as 249033