Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 137993018: Merged r18286, r18289, r18291, r18292, r18299, r18327 into 3.23 branch. (Closed)

Created:
6 years, 11 months ago by Toon Verwaest
Modified:
6 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merged r18286, r18289, r18291, r18292, r18299, r18327 into 3.23 branch. Fix patching the receiver (global object -> global proxy) after the interceptor. Properly restore the receiver after the interceptor call. Fix popping order on ARM. Push receiver and holder separately, given that they can be the same. Fixed global object leak caused by overwriting the global receiver (the global proxy) in the global object with the global object itself. Move the receiver into r0 for PatchGlobalProxy. This fixes the ARM/android bug http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/112686/steps/androidwebview_instrumentation_tests TBR=dcarney@chromium.org BUG=324812 LOG=N R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -133 lines) Patch
include/v8.h View 2 chunks +6 lines, -22 lines 0 comments Download
src/api.cc View 2 chunks +6 lines, -10 lines 0 comments Download
src/arm/stub-cache-arm.cc View 3 chunks +7 lines, -4 lines 0 comments Download
src/bootstrapper.h View 1 chunk +0 lines, -3 lines 0 comments Download
src/bootstrapper.cc View 1 chunk +0 lines, -11 lines 0 comments Download
src/ia32/stub-cache-ia32.cc View 3 chunks +8 lines, -6 lines 0 comments Download
src/objects.h View 3 chunks +5 lines, -0 lines 0 comments Download
src/objects-inl.h View 1 chunk +7 lines, -10 lines 0 comments Download
src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
src/runtime.cc View 1 chunk +10 lines, -0 lines 0 comments Download
src/v8natives.js View 1 chunk +3 lines, -4 lines 0 comments Download
src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
src/x64/stub-cache-x64.cc View 3 chunks +8 lines, -6 lines 0 comments Download
test/cctest/test-api.cc View 7 chunks +62 lines, -35 lines 0 comments Download
test/cctest/test-decls.cc View 1 chunk +3 lines, -3 lines 0 comments Download
test/cctest/test-object-observe.cc View 3 chunks +10 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
6 years, 11 months ago (2014-01-15 16:22:37 UTC) #1
Jakob Kummerow
rubberstamp LGTM
6 years, 11 months ago (2014-01-15 16:23:43 UTC) #2
Toon Verwaest
6 years, 11 months ago (2014-01-15 16:26:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18624 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698