Fix Windows GN build.

Fix Windows GN build.

This sets use_aura on Windows in all cases (fixes base build).

Passes new argument to gyp link wrapper (GYP revision 1835).

R=sky@chromium.org
TBR=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244840

[sky, 2014-01-14 23:35:47]

LGTM

https://codereview.chromium.org/137993014/diff/1/build/config/BUILDCONFIG.gn
File build/config/BUILDCONFIG.gn (right):

https://codereview.chromium.org/137993014/diff/1/build/config/BUILDCONFIG.gn#...
build/config/BUILDCONFIG.gn:109: # Windows currelty implies Aura.
currently

[brettw, 2014-01-15 06:11:04]

Committed patchset #1 manually as r244840 (presubmit successful).

[Matt Giuca, 2014-01-17 03:28:07]

Hey, this CL broke my Windows build when I have:

GYP_DEFINES="use_aura=1"

ERROR at //build/config/BUILDCONFIG.gn:110:3: Overwriting unused variable.
  use_aura = true
  ^-------
This overwrites a previous assignment to "use_aura" that had no effect.
See the command-line "--args" settings:1:34: Previously set here.
is_component_build=true use_aura=true is_gyp=true
                                 ^---
Maybe you wanted "+=" to append instead?
Generating gyp files from GN...

It's not a real problem, I can just do:
export GYP_DEFINES=

but it probably shouldn't break like that.

(Also, "currelty" ;)

[brettw, 2014-01-17 03:30:12]

Yeah, I have a fix for this but haven't gotten it checked in yet. You can remove
the aura setting from GYP since it's redundant now.