Issue 137993003: Revert the feature of the <shadow> element as 'a function call' to the previous behavior.

Issue 137993003: Revert the feature of the <shadow> element as 'a function call' to the previous behavior. (Closed)

Created:
6 years, 11 months ago by hayato

Modified:
6 years, 11 months ago

Reviewers:
esprehn, dglazkov

CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert the feature of the <shadow> element as 'a function call' to the previous behavior. The spec bug is: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24288 The change of the spec is: https://github.com/w3c/webcomponents/commit/61745e0b40c8d609ad1070e7babc7915fca637ea Regarding with https://www.w3.org/Bugs/Public/show_bug.cgi?id=22344, it turned out that there is a kind of a technical difficulty to implement this feature correctly [1]. It might be better to revert it to the previous behavior until we find a reasonable idea of the implementation. We will also remove fallback ability of <shadow> element. Child elements of <shadow> elements will be simply ignored. We preserve the usage of child elements of the <shadow> elements for future use, such as enabling the new behavior again. [1]: https://codereview.chromium.org/77863002/ BUG=334152 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165194

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Update LayoutTests/TestExpectations #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -172 lines)			Patch
M	LayoutTests/TestExpectations	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection-expected.txt	View		5 chunks	+4 lines, -10 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/content-reprojection-fallback.html	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/content-reprojection-fallback-expected.html	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/content-reprojection-fallback-reprojection.html	View		3 chunks	+3 lines, -5 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/content-reprojection-fallback-reprojection-expected.html	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/event-path-multiple-shadow-roots.html	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/event-path-multiple-shadow-roots-expected.txt	View		2 chunks	+3 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/event-path-shadow-insertion-point-in-oldest-shadow-root.html	View		1 chunk	+3 lines, -5 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/event-path-shadow-insertion-point-in-oldest-shadow-root-expected.txt	View		1 chunk	+6 lines, -12 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/nested-reprojection-inconsistent.html	View		1 chunk	+4 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/nested-reprojection-inconsistent-expected.txt	View		1 chunk	+4 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-multiple-shadow-roots.html	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-multiple-shadow-roots-expected.txt	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/fast/dom/shadow/shadow-element-distributed-nodes.html	View		5 chunks	+6 lines, -10 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/shadow-element-distributed-nodes-expected.txt	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/shadow-element-rendering-single.html	View		4 chunks	+1 line, -7 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/shadow-insertion-point-rendering.html	View		1 chunk	+28 lines, -29 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/shadow-insertion-point-rendering-expected.html	View		1 chunk	+12 lines, -12 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/shadow-insertion-point-rendering-multiple-shadow-roots.html	View		3 chunks	+3 lines, -16 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/shadow-insertion-point-rendering-multiple-shadow-roots-expected.html	View		1 chunk	+6 lines, -9 lines	0 comments	Download
M	Source/core/dom/shadow/ElementShadow.cpp	View		1 chunk	+3 lines, -9 lines	0 comments	Download
M	Source/core/dom/shadow/InsertionPoint.cpp	View		1 chunk	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

hayato

Thank you for the reviews. Looks like I have to update tests under w3c/web-platform-tests/ also. ...

6 years, 11 months ago (2014-01-15 04:09:40 UTC) #4

hayato

Let me try to suppress the failing w3c test in https://codereview.chromium.org/138143005/.

6 years, 11 months ago (2014-01-15 06:21:30 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/137993003/100001

6 years, 11 months ago (2014-01-16 03:49:23 UTC) #6

hayato

On 2014/01/15 06:21:30, hayato wrote: > Let me try to suppress the failing w3c test ...

6 years, 11 months ago (2014-01-16 03:49:56 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/137993003/160001

6 years, 11 months ago (2014-01-16 04:15:59 UTC) #8

hayato

On 2014/01/16 03:49:56, hayato wrote: > On 2014/01/15 06:21:30, hayato wrote: > > Let me ...

6 years, 11 months ago (2014-01-16 04:17:44 UTC) #9

Message was sent while issue was closed.

Change committed as 165194

Expand Messages | Collapse Messages