Issue 137993002: IDL compiler: Move include path handling to compute_dependencies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137993002: IDL compiler: Move include path handling to compute_dependencies (Closed)

Created:
6 years, 11 months ago by Nils Barth (inactive)

Modified:
6 years, 11 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

IDL compiler: Move include path handling to compute_dependencies This is a preliminary CL for partial interfaces in the Python IDL compiler. Currently there is code duplication: compute_dependencies.py, idl_compiler, and code_generator_v8.py ...all do path handling. This consolidates it into compute_dependencies.py, so now the compiler doesn't need to know anything about paths. Specifically, this CL means that when we compute and store the full path, we also compute and store the C++ include path for the header. This refactoring will make adding partial interfaces to Python easy: we need include paths of partial interfaces (as this in included in the generated code), and we can store them in the same way. (Currently full path to dependencies is stored.) BUG=239771 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165064

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -19 lines)			Patch
M	Source/bindings/scripts/compute_dependencies.py	View	3 chunks	+16 lines, -3 lines	0 comments	Download
M	Source/bindings/scripts/unstable/code_generator_v8.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/scripts/unstable/idl_compiler.py	View	4 chunks	+1 line, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/137993002/1

6 years, 11 months ago (2014-01-14 10:59:04 UTC) #3

Message was sent while issue was closed.

Change committed as 165064

Expand Messages | Collapse Messages