Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: test/cctest/cctest.cc

Issue 13799003: Change Context::New not create persistent handles. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Adapted cctest initialization to new API. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug.cc ('k') | test/cctest/test-decls.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/cctest.cc
diff --git a/test/cctest/cctest.cc b/test/cctest/cctest.cc
index deed91aa57b54e5f3ba5a54acc559daf6ed1e3c1..a0091ff6f803503d841f1b804daa7890630ae001 100644
--- a/test/cctest/cctest.cc
+++ b/test/cctest/cctest.cc
@@ -68,8 +68,11 @@ void CcTest::InitializeVM(CcTestExtensionFlags extensions) {
EXTENSION_LIST(CHECK_EXTENSION_FLAG)
#undef CHECK_EXTENSION_FLAG
if (context_.IsEmpty()) {
+ v8::Isolate* isolate = default_isolate();
+ v8::HandleScope scope(isolate);
v8::ExtensionConfiguration config(extension_count, extension_names);
- context_ = v8::Context::New(&config);
+ v8::Local<v8::Context> context = v8::Context::New(isolate, &config);
+ context_ = v8::Persistent<v8::Context>::New(isolate, context);
}
context_->Enter();
}
« no previous file with comments | « src/debug.cc ('k') | test/cctest/test-decls.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698