Change Context::New not create persistent handles.

src/bootstrapper.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 285 matching lines @@
   v->Synchronize(VisitorSynchronization::kExtensions);
 }
 
 
 Handle<Context> Bootstrapper::CreateEnvironment(
     Handle<Object> global_object,
     v8::Handle<v8::ObjectTemplate> global_template,
     v8::ExtensionConfiguration* extensions) {
   HandleScope scope(isolate_);
   Genesis genesis(isolate_, global_object, global_template, extensions);
-  if (!genesis.result().is_null()) {
-    Handle<Object> ctx(isolate_->global_handles()->Create(*genesis.result()));
-    Handle<Context> env = Handle<Context>::cast(ctx);
+  Handle<Context> env = genesis.result();
+  if (!env.is_null()) {
     if (InstallExtensions(env, extensions)) {

[Sven Panne, 2013/04/09 07:08:33]

Merge the "if"s, move the last "return" to an "else" branch, swap the "if"
branches by inverting the condition, drop the "else" again. :-) This makes the
normal control flow clearer, with the exceptional cases bailing out early, which
is a good idea:
http://www.refactoring.com/catalog/replaceNestedConditionalWithGuardClauses.html

[Michael Starzinger, 2013/04/09 13:29:18]

Done.

-      return env;
+      return scope.CloseAndEscape(env);
     }
   }
   return Handle<Context>();
 }
 
 
 static void SetObjectPrototype(Handle<JSObject> object, Handle<Object> proto) {
   // object.__proto__ = proto;
   Factory* factory = object->GetIsolate()->factory();
   Handle<Map> old_to_map = Handle<Map>(object->map());
@@ skipping 2174 matching lines @@
   return from + sizeof(NestingCounterType);
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   ASSERT(!IsActive());
 }
 
 } }  // namespace v8::internal