win: Write memory map info as MINIDUMP_MEMORY_INFO[_LIST]

minidump/minidump_memory_info_writer.cc

Index: minidump/minidump_memory_info_writer.cc
diff --git a/minidump/minidump_memory_info_writer.cc b/minidump/minidump_memory_info_writer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3b7e64be59edfffa1429eb515ab217d252aebf96
--- /dev/null
+++ b/minidump/minidump_memory_info_writer.cc
@@ -0,0 +1,88 @@
+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "minidump/minidump_memory_info_writer.h"
+
+#include "base/logging.h"
+#include "snapshot/memory_map_region_snapshot.h"
+#include "util/file/file_writer.h"
+
+namespace crashpad {
+
+MinidumpMemoryInfoListWriter::MinidumpMemoryInfoListWriter()
+    : memory_info_list_(), items_(), total_size_(0) {
+}
+
+MinidumpMemoryInfoListWriter::~MinidumpMemoryInfoListWriter() {
+}
+
+void MinidumpMemoryInfoListWriter::InitializeFromSnapshot(
+    const std::vector<const MemoryMapRegionSnapshot*>& memory_map) {
+  DCHECK_EQ(state(), kStateMutable);
+
+  DCHECK(items_.empty());
+  for (const auto& region : memory_map)
+    items_.push_back(region->AsMinidumpMemoryInfo());
+}
+
+bool MinidumpMemoryInfoListWriter::Freeze() {
+  DCHECK_EQ(state(), kStateMutable);
+
+  if (!MinidumpStreamWriter::Freeze())
+    return false;
+
+  memory_info_list_.SizeOfHeader = sizeof(MINIDUMP_MEMORY_INFO_LIST);
+  memory_info_list_.SizeOfEntry = sizeof(MINIDUMP_MEMORY_INFO);
+  memory_info_list_.NumberOfEntries = items_.size();
+
+  total_size_ = sizeof(MINIDUMP_MEMORY_INFO_LIST) +

[Mark Mentovai, 2015/10/12 14:34:46]

You don’t need total_size_ as a member, you can compute it in SizeOfObject().
That’s what the other list writers do.

It should be sizeof(memory_info_list_) + items_.size() * sizeof(items_[0]). Use
sizeof with variables instead of types when possible.

[scottmg, 2015/10/13 19:51:29]

Done.

+                sizeof(MINIDUMP_MEMORY_INFO) * items_.size();
+
+  return true;
+}
+
+size_t MinidumpMemoryInfoListWriter::SizeOfObject() {
+  DCHECK_GE(state(), kStateFrozen);
+  return total_size_;
+}
+
+std::vector<internal::MinidumpWritable*>
+MinidumpMemoryInfoListWriter::Children() {
+  DCHECK_GE(state(), kStateFrozen);
+  return std::vector<internal::MinidumpWritable*>();
+}
+
+bool MinidumpMemoryInfoListWriter::WriteObject(
+    FileWriterInterface* file_writer) {
+  DCHECK_EQ(state(), kStateWritable);
+
+  WritableIoVec iov;
+  iov.iov_base = &memory_info_list_;
+  iov.iov_len = sizeof(memory_info_list_);
+  std::vector<WritableIoVec> iovecs(1, iov);
+
+  for (const auto& minidump_memory_info : items_) {
+    iov.iov_base = &minidump_memory_info;
+    iov.iov_len = sizeof(minidump_memory_info);
+    iovecs.push_back(iov);
+  }
+
+  return file_writer->WriteIoVec(&iovecs);
+}
+
+MinidumpStreamType MinidumpMemoryInfoListWriter::StreamType() const {
+  return kMinidumpStreamTypeMemoryInfoList;
+}
+
+}  // namespace crashpad