Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1379863002: Fix SK_API macro in SkTraceMemoryDump_Chrome (Closed)

Created:
5 years, 2 months ago by ssid
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@add_sub_chrome
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix SK_API macro in SkTraceMemoryDump_Chrome Add the missing macro for export. TBR=reed@google.com Committed: https://crrev.com/f940fe3186a24d2abdbbf469a6e7ee66161f55ce Cr-Commit-Position: refs/heads/master@{#351618}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M skia/ext/SkTraceMemoryDump_chrome.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379863002/20001
5 years, 2 months ago (2015-09-30 17:22:27 UTC) #3
Primiano Tucci (use gerrit)
lgtm
5 years, 2 months ago (2015-09-30 17:30:15 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 18:40:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379863002/20001
5 years, 2 months ago (2015-09-30 19:08:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 2 months ago (2015-09-30 19:36:05 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 19:37:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f940fe3186a24d2abdbbf469a6e7ee66161f55ce
Cr-Commit-Position: refs/heads/master@{#351618}

Powered by Google App Engine
This is Rietveld 408576698