Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1379833002: [heap] Properly account for wasted bytes. (Closed)

Created:
5 years, 2 months ago by Michael Lippautz
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Properly account for wasted bytes. - Wasted bytes are now accounted where they accrue, i.e., the corresponding free list. The amount of waste is transferred by concatenating free lists. - During concatenation, free lists are no longer locked on FreeListCategory level, but in the FreeList itself, simplifying the sync between contained nodes and wasted bytes (which are effectively dropped nodes). This is pre-work for properly moving memory to compaction spaces, which requires correct accounting of wasted memory. BUG=chromium:524425 LOG=N Committed: https://crrev.com/7a6f47fe22323b574f2fffe5425a16ba516fd7a5 Cr-Commit-Position: refs/heads/master@{#31040}

Patch Set 1 #

Patch Set 2 : Move code comments to declaration site of fields #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -55 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/spaces.h View 1 13 chunks +25 lines, -41 lines 0 comments Download
M src/heap/spaces.cc View 6 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379833002/1
5 years, 2 months ago (2015-09-30 15:02:03 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 15:25:12 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379833002/20001
5 years, 2 months ago (2015-09-30 18:32:54 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 18:55:52 UTC) #8
Michael Lippautz
PTAL (also at ia32 perf)
5 years, 2 months ago (2015-10-01 07:50:05 UTC) #10
Hannes Payer (out of office)
lgtm
5 years, 2 months ago (2015-10-01 08:10:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379833002/20001
5 years, 2 months ago (2015-10-01 08:12:36 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-01 08:14:14 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 08:14:33 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a6f47fe22323b574f2fffe5425a16ba516fd7a5
Cr-Commit-Position: refs/heads/master@{#31040}

Powered by Google App Engine
This is Rietveld 408576698