Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: Source/core/css/resolver/StyleResourceLoader.cpp

Issue 137983010: (Re)organize handling of CORS access control during resource loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: HTMLImportLoader no longer needs a ResourceFetcher Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSImageValue.cpp ('k') | Source/core/dom/ScriptLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/resolver/StyleResourceLoader.cpp
diff --git a/Source/core/css/resolver/StyleResourceLoader.cpp b/Source/core/css/resolver/StyleResourceLoader.cpp
index 3476ba43ae7a73452d228bb0a7e0d4e47e67b47c..0b20f735619c02f02d59deaa392d97133fc94ec9 100644
--- a/Source/core/css/resolver/StyleResourceLoader.cpp
+++ b/Source/core/css/resolver/StyleResourceLoader.cpp
@@ -70,10 +70,10 @@ void StyleResourceLoader::loadPendingSVGDocuments(RenderStyle* renderStyle, cons
}
}
-static PassRefPtr<StyleImage> doLoadPendingImage(ResourceFetcher* fetcher, StylePendingImage* pendingImage, float deviceScaleFactor, const ResourceLoaderOptions& options, CORSEnabled corsEnabled)
+static PassRefPtr<StyleImage> doLoadPendingImage(ResourceFetcher* fetcher, StylePendingImage* pendingImage, float deviceScaleFactor, const ResourceLoaderOptions& options)
{
if (CSSImageValue* imageValue = pendingImage->cssImageValue())
- return imageValue->cachedImage(fetcher, options, corsEnabled);
+ return imageValue->cachedImage(fetcher, options);
if (CSSImageGeneratorValue* imageGeneratorValue
= pendingImage->cssImageGeneratorValue()) {
@@ -86,14 +86,14 @@ static PassRefPtr<StyleImage> doLoadPendingImage(ResourceFetcher* fetcher, Style
return cursorImageValue->cachedImage(fetcher, deviceScaleFactor);
if (CSSImageSetValue* imageSetValue = pendingImage->cssImageSetValue())
- return imageSetValue->cachedImageSet(fetcher, deviceScaleFactor, options, corsEnabled);
+ return imageSetValue->cachedImageSet(fetcher, deviceScaleFactor, options);
return 0;
}
PassRefPtr<StyleImage> StyleResourceLoader::loadPendingImage(StylePendingImage* pendingImage, float deviceScaleFactor)
{
- return doLoadPendingImage(m_fetcher, pendingImage, deviceScaleFactor, ResourceFetcher::defaultResourceOptions(), NotCORSEnabled);
+ return doLoadPendingImage(m_fetcher, pendingImage, deviceScaleFactor, ResourceFetcher::defaultResourceOptions());
}
void StyleResourceLoader::loadPendingShapeImage(RenderStyle* renderStyle, ShapeValue* shapeValue, float deviceScaleFactor)
@@ -107,8 +107,9 @@ void StyleResourceLoader::loadPendingShapeImage(RenderStyle* renderStyle, ShapeV
ResourceLoaderOptions options = ResourceFetcher::defaultResourceOptions();
options.allowCredentials = DoNotAllowStoredCredentials;
+ options.corsEnabled = IsCORSEnabled;
- shapeValue->setImage(doLoadPendingImage(m_fetcher, toStylePendingImage(image), deviceScaleFactor, options, PotentiallyCORSEnabled));
+ shapeValue->setImage(doLoadPendingImage(m_fetcher, toStylePendingImage(image), deviceScaleFactor, options));
}
void StyleResourceLoader::loadPendingImages(RenderStyle* style, const ElementStyleResources& elementStyleResources)
« no previous file with comments | « Source/core/css/CSSImageValue.cpp ('k') | Source/core/dom/ScriptLoader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698