Issue 137983002: Remove existingWindowShellWorkaroundWorld

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137983002: Remove existingWindowShellWorkaroundWorld (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 11 months ago

Reviewers:
haraken, dcarney, abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, gavinp+loader_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove existingWindowShellWorkaroundWorld This was used to notify the inspector only of events originating from the FrameLoader. Instead, do this explicitly BUG=none R=dcarney@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165056

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -31 lines)			Patch
M	Source/bindings/v8/DOMWrapperWorld.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/bindings/v8/DOMWrapperWorld.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/bindings/v8/ScriptController.cpp	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	Source/core/loader/FrameLoader.cpp	View	2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/137983002/1

6 years, 11 months ago (2014-01-14 09:02:29 UTC) #3

Message was sent while issue was closed.

yay!  Glad to see this go.

Expand Messages | Collapse Messages