Adds class, id and src attributes to object attributes of IA2.

Adds class, id and src attributes to object attributes of IA2.

This patch adds class, id and src attributes to object attributes of IA2
and introduces UpdateRequiredAttributes() which updates required
attributes for IA2 with html attributes.

BUG=498342
Committed: https://crrev.com/9aabab1f1942caeb464ed90c63ba0f79d8bfcf5d
Cr-Commit-Position: refs/heads/master@{#353943}

[je_julie(Not used), 2015-10-05 11:41:15]

je_julie.kim@samsung.com changed reviewers:
+ dmazzoni@chromium.org, dtseng@chromium.org

[je_julie(Not used), 2015-10-05 11:41:16]

Hi David,

This patch makes IA2 has class, id and src attributes.
PTAL.

[dmazzoni, 2015-10-12 22:30:21]

Hi Julie! Sorry I didn't see this before I left on vacation.

This looks great, but Nektarios just landed this change that escapes string
attributes - could you rebase your change on top of that one?

https://codereview.chromium.org/1397183002/

Then it should be good to go. Thanks!

[dmazzoni, 2015-10-12 22:31:40]

https://codereview.chromium.org/1379803002/diff/20001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/1379803002/diff/20001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:4078: if (GetRole()
== ui::AX_ROLE_TEXT_FIELD &&
Perhaps we should check if the HTML tag is "input", because we should ignore
"type" for a textarea element, for example.

[je_julie(Not used), 2015-10-13 16:54:09]

Dominic,
Thanks for the comment.
I rebased this patch and added the condition for input tag.
PTAL.

https://codereview.chromium.org/1379803002/diff/20001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/1379803002/diff/20001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:4078: if (GetRole()
== ui::AX_ROLE_TEXT_FIELD &&
On 2015/10/12 22:31:39, dmazzoni wrote:
> Perhaps we should check if the HTML tag is "input", because we should ignore
> "type" for a textarea element, for example.

Done.

[dmazzoni, 2015-10-13 17:19:25]

lgtm

Thanks!

[je_julie(Not used), 2015-10-14 00:47:48]

The CQ bit was checked by je_julie.kim@samsung.com

[commit-bot: I haz the power, 2015-10-14 00:49:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1379803002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1379803002/60001

[commit-bot: I haz the power, 2015-10-14 02:16:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-14 02:17:42]

Patchset 4 (id:??) landed as
https://crrev.com/9aabab1f1942caeb464ed90c63ba0f79d8bfcf5d
Cr-Commit-Position: refs/heads/master@{#353943}

[je_julie(Not used), 2015-12-22 09:09:24]

Patchset #5 (id:80001) has been deleted