Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: cc/raster/tile_task_worker_pool.cc

Issue 1379783002: Allow one-copy task tile worker pool to use compressed textures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove needs_conversion, fix tile size unit test and move modulo 4 DCHECK (for tests) Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/raster/tile_task_worker_pool.h" 5 #include "cc/raster/tile_task_worker_pool.h"
6 6
7 #include "base/trace_event/trace_event.h" 7 #include "base/trace_event/trace_event.h"
8 #include "cc/playback/display_list_raster_source.h" 8 #include "cc/playback/display_list_raster_source.h"
9 #include "cc/raster/texture_compressor.h"
9 #include "skia/ext/refptr.h" 10 #include "skia/ext/refptr.h"
10 #include "third_party/skia/include/core/SkCanvas.h" 11 #include "third_party/skia/include/core/SkCanvas.h"
11 #include "third_party/skia/include/core/SkDrawFilter.h" 12 #include "third_party/skia/include/core/SkDrawFilter.h"
12 #include "third_party/skia/include/core/SkSurface.h" 13 #include "third_party/skia/include/core/SkSurface.h"
13 14
14 namespace cc { 15 namespace cc {
15 16
16 TileTaskWorkerPool::TileTaskWorkerPool() {} 17 TileTaskWorkerPool::TileTaskWorkerPool() {}
17 18
18 TileTaskWorkerPool::~TileTaskWorkerPool() {} 19 TileTaskWorkerPool::~TileTaskWorkerPool() {}
(...skipping 14 matching lines...) Expand all
33 task->DidSchedule(); 34 task->DidSchedule();
34 } 35 }
35 } 36 }
36 } 37 }
37 38
38 static bool IsSupportedPlaybackToMemoryFormat(ResourceFormat format) { 39 static bool IsSupportedPlaybackToMemoryFormat(ResourceFormat format) {
39 switch (format) { 40 switch (format) {
40 case RGBA_4444: 41 case RGBA_4444:
41 case RGBA_8888: 42 case RGBA_8888:
42 case BGRA_8888: 43 case BGRA_8888:
44 case ETC1:
43 return true; 45 return true;
44 case ALPHA_8: 46 case ALPHA_8:
45 case LUMINANCE_8: 47 case LUMINANCE_8:
46 case RGB_565: 48 case RGB_565:
47 case ETC1:
48 case RED_8: 49 case RED_8:
49 return false; 50 return false;
50 } 51 }
51 NOTREACHED(); 52 NOTREACHED();
52 return false; 53 return false;
53 } 54 }
54 55
55 class SkipImageFilter : public SkDrawFilter { 56 class SkipImageFilter : public SkDrawFilter {
56 public: 57 public:
57 bool filter(SkPaint* paint, Type type) override { 58 bool filter(SkPaint* paint, Type type) override {
(...skipping 16 matching lines...) Expand all
74 const gfx::Rect& canvas_playback_rect, 75 const gfx::Rect& canvas_playback_rect,
75 float scale, 76 float scale,
76 bool include_images) { 77 bool include_images) {
77 TRACE_EVENT0("cc", "TileTaskWorkerPool::PlaybackToMemory"); 78 TRACE_EVENT0("cc", "TileTaskWorkerPool::PlaybackToMemory");
78 79
79 DCHECK(IsSupportedPlaybackToMemoryFormat(format)) << format; 80 DCHECK(IsSupportedPlaybackToMemoryFormat(format)) << format;
80 81
81 // Uses kPremul_SkAlphaType since the result is not known to be opaque. 82 // Uses kPremul_SkAlphaType since the result is not known to be opaque.
82 SkImageInfo info = 83 SkImageInfo info =
83 SkImageInfo::MakeN32(size.width(), size.height(), kPremul_SkAlphaType); 84 SkImageInfo::MakeN32(size.width(), size.height(), kPremul_SkAlphaType);
84 SkColorType buffer_color_type = ResourceFormatToSkColorType(format);
85 bool needs_copy = buffer_color_type != info.colorType();
86 85
87 // Use unknown pixel geometry to disable LCD text. 86 // Use unknown pixel geometry to disable LCD text.
88 SkSurfaceProps surface_props(0, kUnknown_SkPixelGeometry); 87 SkSurfaceProps surface_props(0, kUnknown_SkPixelGeometry);
89 if (raster_source->CanUseLCDText()) { 88 if (raster_source->CanUseLCDText()) {
90 // LegacyFontHost will get LCD text and skia figures out what type to use. 89 // LegacyFontHost will get LCD text and skia figures out what type to use.
91 surface_props = SkSurfaceProps(SkSurfaceProps::kLegacyFontHost_InitType); 90 surface_props = SkSurfaceProps(SkSurfaceProps::kLegacyFontHost_InitType);
92 } 91 }
93 92
94 if (!stride) 93 if (!stride)
95 stride = info.minRowBytes(); 94 stride = info.minRowBytes();
96 DCHECK_GT(stride, 0u); 95 DCHECK_GT(stride, 0u);
97 96
98 skia::RefPtr<SkDrawFilter> image_filter; 97 skia::RefPtr<SkDrawFilter> image_filter;
99 if (!include_images) 98 if (!include_images)
100 image_filter = skia::AdoptRef(new SkipImageFilter); 99 image_filter = skia::AdoptRef(new SkipImageFilter);
101 100
102 if (!needs_copy) {
103 skia::RefPtr<SkSurface> surface = skia::AdoptRef(
104 SkSurface::NewRasterDirect(info, memory, stride, &surface_props));
105 skia::RefPtr<SkCanvas> canvas = skia::SharePtr(surface->getCanvas());
106 canvas->setDrawFilter(image_filter.get());
107 raster_source->PlaybackToCanvas(canvas.get(), canvas_bitmap_rect,
108 canvas_playback_rect, scale);
109 return;
110 }
111
112 skia::RefPtr<SkSurface> surface =
113 skia::AdoptRef(SkSurface::NewRaster(info, &surface_props));
114 skia::RefPtr<SkCanvas> canvas = skia::SharePtr(surface->getCanvas());
115 canvas->setDrawFilter(image_filter.get());
116 // TODO(reveman): Improve partial raster support by reducing the size of
117 // playback rect passed to PlaybackToCanvas. crbug.com/519070
118 raster_source->PlaybackToCanvas(canvas.get(), canvas_bitmap_rect,
119 canvas_bitmap_rect, scale);
120
121 { 101 {
122 TRACE_EVENT0("cc", "TileTaskWorkerPool::PlaybackToMemory::ConvertPixels"); 102 TRACE_EVENT0("cc", "TileTaskWorkerPool::PlaybackToMemory::ConvertPixels");
123 103
124 SkImageInfo dst_info = 104 switch (format) {
125 SkImageInfo::Make(info.width(), info.height(), buffer_color_type, 105 case RGBA_8888:
126 info.alphaType(), info.profileType()); 106 case BGRA_8888: {
127 bool rv = canvas->readPixels(dst_info, memory, stride, 0, 0); 107 skia::RefPtr<SkSurface> surface = skia::AdoptRef(
128 DCHECK(rv); 108 SkSurface::NewRasterDirect(info, memory, stride, &surface_props));
109 skia::RefPtr<SkCanvas> canvas = skia::SharePtr(surface->getCanvas());
110 canvas->setDrawFilter(image_filter.get());
111 raster_source->PlaybackToCanvas(canvas.get(), canvas_bitmap_rect,
112 canvas_playback_rect, scale);
113 return;
114 }
115 case RGBA_4444:
116 case ETC1: {
117 skia::RefPtr<SkSurface> surface =
118 skia::AdoptRef(SkSurface::NewRaster(info, &surface_props));
119 skia::RefPtr<SkCanvas> canvas = skia::SharePtr(surface->getCanvas());
120 canvas->setDrawFilter(image_filter.get());
121 // TODO(reveman): Improve partial raster support by reducing the size of
122 // playback rect passed to PlaybackToCanvas. crbug.com/519070
123 raster_source->PlaybackToCanvas(canvas.get(), canvas_bitmap_rect,
124 canvas_bitmap_rect, scale);
reveman 2015/12/09 17:29:37 nit: maybe move l.117-124 to a utility function so
125
126 if (format == ETC1) {
127 DCHECK_EQ(size.width() % 4, 0);
128 DCHECK_EQ(size.height() % 4, 0);
129 scoped_ptr<TextureCompressor> texture_compressor =
130 TextureCompressor::Create(TextureCompressor::kFormatETC1);
131 texture_compressor->Compress(
132 reinterpret_cast<const uint8_t*>(
133 surface->peekPixels(nullptr, nullptr)),
134 reinterpret_cast<uint8_t*>(memory), size.width(), size.height(),
135 TextureCompressor::kQualityHigh);
136 } else {
137 SkImageInfo dst_info = SkImageInfo::Make(
138 info.width(), info.height(), ResourceFormatToSkColorType(format),
139 info.alphaType(), info.profileType());
140 bool rv = canvas->readPixels(dst_info, memory, stride, 0, 0);
141 DCHECK(rv);
142 }
143 return;
144 }
145 case ALPHA_8:
146 case LUMINANCE_8:
147 case RGB_565:
148 case RED_8:
149 NOTREACHED();
150 return;
151 }
152
153 NOTREACHED();
129 } 154 }
130 } 155 }
131 156
132 } // namespace cc 157 } // namespace cc
OLDNEW
« no previous file with comments | « cc/raster/one_copy_tile_task_worker_pool.cc ('k') | cc/raster/tile_task_worker_pool_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698