Allow one-copy task tile worker pool to use compressed textures.

content/renderer/gpu/render_widget_compositor.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/gpu/render_widget_compositor.h"
 
 #include <limits>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 15 matching lines @@
 #include "cc/debug/layer_tree_debug_state.h"
 #include "cc/debug/micro_benchmark.h"
 #include "cc/input/layer_selection_bound.h"
 #include "cc/layers/layer.h"
 #include "cc/output/begin_frame_args.h"
 #include "cc/output/copy_output_request.h"
 #include "cc/output/copy_output_result.h"
 #include "cc/output/latency_info_swap_promise.h"
 #include "cc/output/swap_promise.h"
 #include "cc/proto/compositor_message.pb.h"
+#include "cc/resources/platform_color.h"

[reveman, 2015/12/02 18:27:18]

nit: I don't think you need this with the changes I suggest below

[christiank, 2015/12/03 12:57:59]

Done.

 #include "cc/resources/single_release_callback.h"
 #include "cc/scheduler/begin_frame_source.h"
 #include "cc/trees/latency_info_swap_promise_monitor.h"
 #include "cc/trees/layer_tree_host.h"
 #include "cc/trees/remote_proto_channel.h"
 #include "components/scheduler/renderer/renderer_scheduler.h"
 #include "content/common/content_switches_internal.h"
 #include "content/common/gpu/client/context_provider_command_buffer.h"
 #include "content/public/common/content_switches.h"
 #include "content/renderer/input/input_handler_manager.h"
@@ skipping 355 matching lines @@
     settings.scrollbar_fade_duration_ms = 300;
     settings.solid_color_scrollbar_color = SkColorSetARGB(128, 128, 128, 128);
   }
   settings.renderer_settings.highp_threshold_min = 2048;
   // Android WebView handles root layer flings itself.
   settings.ignore_root_layer_flings = using_synchronous_compositor;
   // Memory policy on Android WebView does not depend on whether device is
   // low end, so always use default policy.
   bool use_low_memory_policy =
       base::SysInfo::IsLowEndDevice() && !using_synchronous_compositor;
-  // RGBA_4444 textures are only enabled by default for low end devices
-  // and are disabled for Android WebView as it doesn't support the format.
-  settings.renderer_settings.use_rgba_4444_textures = use_low_memory_policy;
   if (use_low_memory_policy) {
     // On low-end we want to be very carefull about killing other
     // apps. So initially we use 50% more memory to avoid flickering
     // or raster-on-demand.
     settings.max_memory_for_prepaint_percentage = 67;
+
+    // RGBA_4444 textures are only enabled by default for low end devices
+    // and are disabled for Android WebView as it doesn't support the format.
+    settings.renderer_settings.preferred_tile_format = cc::RGBA_4444;

[reveman, 2015/12/02 18:27:18]

nit: if (!cmd->HasSwitch(switches::kDisableRGBA4444Textures)) here and remove
that check below so we don't have to call BestTextureFormat in here and can just
leave the setting as default

[christiank, 2015/12/03 12:58:00]

Done.

   } else {
     // On other devices we have increased memory excessively to avoid
     // raster-on-demand already, so now we reserve 50% _only_ to avoid
     // raster-on-demand, and use 50% of the memory otherwise.
     settings.max_memory_for_prepaint_percentage = 50;
   }
   // Webview does not own the surface so should not clear it.
   settings.renderer_settings.should_clear_root_render_pass =
       !using_synchronous_compositor;
 
@@ skipping 15 matching lines @@
   settings.scrollbar_fade_duration_ms = 300;
 #endif
 
   if (cmd->HasSwitch(switches::kEnableLowResTiling))
     settings.create_low_res_tiling = true;
   if (cmd->HasSwitch(switches::kDisableLowResTiling))
     settings.create_low_res_tiling = false;
   if (cmd->HasSwitch(cc::switches::kEnableBeginFrameScheduling))
     settings.use_external_begin_frame_source = true;
 
-  settings.renderer_settings.use_rgba_4444_textures |=
-      cmd->HasSwitch(switches::kEnableRGBA4444Textures);
-  settings.renderer_settings.use_rgba_4444_textures &=
-      !cmd->HasSwitch(switches::kDisableRGBA4444Textures);
+  if (cmd->HasSwitch(switches::kEnableRGBA4444Textures)) {
+    settings.renderer_settings.preferred_tile_format = cc::RGBA_4444;
+  }
+  if (cmd->HasSwitch(switches::kDisableRGBA4444Textures)) {

[reveman, 2015/12/02 18:27:18]

nit: please make setting referred_tile_format to RGBA_4444 at l.420 conditional
on this instead. see the comment above.

[christiank, 2015/12/03 12:58:00]

Done.

+    // Assume BGRA is supported here, if the preferred tile format isn't
+    // supported the compositor will choose the best supported format for us.
+    settings.renderer_settings.preferred_tile_format =
+        cc::PlatformColor::BestTextureFormat(true);
+  }
+
+  if (cmd->HasSwitch(cc::switches::kEnableTileCompression)) {
+    settings.renderer_settings.preferred_tile_format = cc::ETC1;
+  }
 
   if (widget_->for_oopif()) {
     // TODO(simonhong): Apply BeginFrame scheduling for OOPIF.
     // See crbug.com/471411.
     settings.use_external_begin_frame_source = false;
   }
 
   settings.max_staging_buffer_usage_in_bytes = 32 * 1024 * 1024;  // 32MB
   // Use 1/4th of staging buffers on low-end devices.
   if (base::SysInfo::IsLowEndDevice())
@@ skipping 648 matching lines @@
 #endif
   return actual;
 }
 
 void RenderWidgetCompositor::SetPaintedDeviceScaleFactor(
     float device_scale) {
   layer_tree_host_->SetPaintedDeviceScaleFactor(device_scale);
 }
 
 }  // namespace content