Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1379693002: GN: Remove irrelevant targets for Cast Android build (Closed)

Created:
5 years, 2 months ago by pkotwicz
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Remove irrelevant targets for Cast Android build This CL mirrors the logic in all.gyp in BUILD.gn BUG=None TEST=None Committed: https://crrev.com/061c5a47235bb75213dfa75548aaef590094a639 Cr-Commit-Position: refs/heads/master@{#351473}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M BUILD.gn View 1 2 chunks +8 lines, -3 lines 0 comments Download
M build/gn_migration.gypi View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pkotwicz
dpranke@ can you please take a look? Do I need to modify build/gn_migration.gypi as well? ...
5 years, 2 months ago (2015-09-29 21:24:18 UTC) #2
Dirk Pranke
the BUILD.gn change lgtm. Ideally, yes, you would update gn_migration.gypi as well. The bug was ...
5 years, 2 months ago (2015-09-29 22:35:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379693002/20001
5 years, 2 months ago (2015-09-30 00:40:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/103584)
5 years, 2 months ago (2015-09-30 00:53:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379693002/20001
5 years, 2 months ago (2015-09-30 01:48:26 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-30 02:17:04 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 02:17:52 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/061c5a47235bb75213dfa75548aaef590094a639
Cr-Commit-Position: refs/heads/master@{#351473}

Powered by Google App Engine
This is Rietveld 408576698