Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 137963002: Various API-related simplifications. (Closed)

Created:
6 years, 11 months ago by Sven Panne
Modified:
6 years, 11 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Various API-related simplifications. * Simplified default fatal error handler. * Simplified Context::Exit and friends. * Inline API_ENTRY_CHECK. R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18577

Patch Set 1 #

Patch Set 2 : Re-added LeaveContext check. #

Patch Set 3 : Rebased. #

Patch Set 4 : upload trouble #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -51 lines) Patch
M src/api.h View 1 2 chunks +8 lines, -6 lines 0 comments Download
M src/api.cc View 1 4 chunks +22 lines, -32 lines 0 comments Download
M src/checks.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/v8checks.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 11 months ago (2014-01-14 08:16:45 UTC) #1
dcarney
lgtm
6 years, 11 months ago (2014-01-14 08:22:18 UTC) #2
Sven Panne
6 years, 11 months ago (2014-01-14 09:37:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r18577 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698