Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1379613005: Add include files so that IceCompilerServer.cpp can compile on MSC. (Closed)

Created:
5 years, 2 months ago by Karl
Modified:
5 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add include files so that IceCompilerServer.cpp can compile on MSC. A recent change to IceCompilerServer.cpp was added to allow fatal errors to return exit status zero. However, this code called ::write (a C function) that is not defined when compiling with MSC. This CL adds includes to fix this problem. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=166cbf4a312ce849d38e8799237c47e3d8d6807c

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/IceCompileServer.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Karl
5 years, 2 months ago (2015-10-01 19:24:56 UTC) #2
Jim Stichnoth
lgtm
5 years, 2 months ago (2015-10-01 20:25:41 UTC) #3
Karl
5 years, 2 months ago (2015-10-01 21:23:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
166cbf4a312ce849d38e8799237c47e3d8d6807c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698