Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1379603006: [Oilpan] Refactoring: Rename GarbageCollectedBase to GarbageCollectedType (Closed)

Created:
5 years, 2 months ago by peria
Modified:
5 years, 2 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, asanka, oilpan-reviews, Mads Ager (chromium), benjhayden+dwatch_chromium.org, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring: Rename GarbageCollectedBase to GarbageCollectedType. For many templates, FooBarBase is used to describe a generic template for FooBar. This change is to avoid confusing names for the rule. BUG=None Committed: https://crrev.com/bc965582dc723bf48d1eab2746bc8c660092f17b Cr-Commit-Position: refs/heads/master@{#352297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M third_party/WebKit/Source/platform/heap/GCInfo.h View 2 chunks +16 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
peria
PTL
5 years, 2 months ago (2015-10-05 05:12:28 UTC) #2
haraken
LGTM
5 years, 2 months ago (2015-10-05 05:13:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379603006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379603006/1
5 years, 2 months ago (2015-10-05 05:18:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 06:55:55 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 06:56:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc965582dc723bf48d1eab2746bc8c660092f17b
Cr-Commit-Position: refs/heads/master@{#352297}

Powered by Google App Engine
This is Rietveld 408576698