Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1379543003: Revert of Post loading tasks on the appropriate WebFrameScheduler's queue (Closed)

Created:
5 years, 2 months ago by dmurph
Modified:
5 years, 2 months ago
CC:
blink-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Post loading tasks on the appropriate WebFrameScheduler's queue (patchset #17 id:310001 of https://codereview.chromium.org/1366883002/ ) Reason for revert: BUG=538660 HTTP parsing use-after-free issues. Original issue's description: > Post loading tasks on the appropriate WebFrameScheduler's queue. > > Must be submitted after https://codereview.chromium.org/1340343003/ > > BUG=510398 > > Committed: https://crrev.com/bcc4ce71b07ea71a1056c3227c5bc381c52256fd > Cr-Commit-Position: refs/heads/master@{#352036} TBR=jochen@chromium.org,sandersd@chromium.org,skyostil@chromium.org,alexclarke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510398 Committed: https://crrev.com/08a17b907128a90d72f8d8031985b34a54aaf45d Cr-Commit-Position: refs/heads/master@{#352062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -345 lines) Patch
M components/html_viewer/web_url_loader_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/web_url_loader_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/scheduler/child/web_task_runner_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/scheduler/child/web_task_runner_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/blink_platform_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/blink_platform_impl.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M content/child/request_info.h View 2 chunks +0 lines, -8 lines 0 comments Download
M content/child/request_info.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/resource_dispatcher.h View 3 chunks +0 lines, -5 lines 0 comments Download
M content/child/resource_dispatcher.cc View 4 chunks +0 lines, -16 lines 0 comments Download
M content/child/resource_scheduling_filter.h View 2 chunks +2 lines, -23 lines 0 comments Download
M content/child/resource_scheduling_filter.cc View 2 chunks +3 lines, -56 lines 0 comments Download
M content/child/web_url_loader_impl.h View 2 chunks +3 lines, -5 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 13 chunks +10 lines, -45 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 4 chunks +0 lines, -16 lines 0 comments Download
M content/test/mock_weburlloader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/weburl_loader_mock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/weburl_loader_mock.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/blink/mock_weburlloader.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h View 5 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 11 chunks +9 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp View 12 chunks +10 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchContext.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 4 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/TimerTest.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoader.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/WebTaskRunner.h View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLLoader.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmurph
Created Revert of Post loading tasks on the appropriate WebFrameScheduler's queue
5 years, 2 months ago (2015-10-02 17:07:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379543003/1
5 years, 2 months ago (2015-10-02 17:08:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 17:11:09 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 17:11:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08a17b907128a90d72f8d8031985b34a54aaf45d
Cr-Commit-Position: refs/heads/master@{#352062}

Powered by Google App Engine
This is Rietveld 408576698