Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1379513002: Revert of Clean up rewriter. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
Reviewers:
neis, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Clean up rewriter. (patchset #3 id:40001 of https://codereview.chromium.org/1362333002/ ) Reason for revert: [Sheriff] Seems to break layout tests: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/2073 https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64/2073/layout-test-results/results.html Please request rebaseline upstream first. Original issue's description: > Clean up rewriter. > > The main changes are: > - Fix treatment of loops, which was incorrect and sometimes resulted in > the wrong completion value. > - Get rid of unnecessary variables. > > This is in preparation of implementing ES6 completion semantics. > > R=rossberg > BUG= > > Committed: https://crrev.com/b466dc14791844b7ae6d1e9ebd00a778965c206d > Cr-Commit-Position: refs/heads/master@{#30981} TBR=rossberg@chromium.org,neis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/283981158449b36fa27eb5d4ad2a99734518b3c7 Cr-Commit-Position: refs/heads/master@{#30992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -56 lines) Patch
M src/rewriter.cc View 7 chunks +59 lines, -46 lines 0 comments Download
M test/webkit/eval-throw-return.js View 1 chunk +5 lines, -5 lines 0 comments Download
M test/webkit/eval-throw-return-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Clean up rewriter.
5 years, 2 months ago (2015-09-29 04:52:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379513002/1
5 years, 2 months ago (2015-09-29 04:53:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 04:53:11 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 04:53:26 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/283981158449b36fa27eb5d4ad2a99734518b3c7
Cr-Commit-Position: refs/heads/master@{#30992}

Powered by Google App Engine
This is Rietveld 408576698