third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py - Issue 1379493002: Use chromium revision instead of blink svn revision when rebaselining layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py

Issue 1379493002: Use chromium revision instead of blink svn revision when rebaselining layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_mock.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py

index 1dbd33f1b9197b1fcb6194ea77f284a2f94cffcc..5eece7346daa326d64745bb0ebc6a6e0d9c9dc7f 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py

@@ -116,11 +116,8 @@ class SCM:

def display_name(self):

self._subclass_must_implement()

- def _head_svn_revision(self):

- return self.svn_revision(self.checkout_root)

- def svn_revision(self, path):

- """Returns the latest svn revision found in the checkout."""

+ def chromium_revision(self, path):

+ """Returns the latest chromium revision found in the checkout."""

self._subclass_must_implement()

def timestamp_of_revision(self, path, revision):