Chromium Code Reviews Chromium Code Reviews
Issue
1379473002:
Revert of Add crash_service to Telemetry's isolates. (Closed)
DescriptionRevert of Add crash_service to Telemetry's isolates. (patchset #8 id:180001 of https://codereview.chromium.org/1361523003/ )
Reason for revert:
Suspected build fail see https://code.google.com/p/chromium/issues/detail?id=536998 and https://code.google.com/p/chromium/issues/detail?id=537065
Original issue's description:
> Add crash_service to Telemetry's isolates.
>
> Switch to using binary_manager for the crash_service executable,
> eliminating downloads of this binary from cloud storage. (A follow-on
> CL will likely forbid the bots from downloading this and other
> executables from cloud storage entirely, rather than continuing to use
> this as a fallback path.)
>
> Telemetry's isolates are currently specified fairly differently for
> the GYP and GN builds; other CLs underway will unify their
> specification more.
>
> Follow up CL's will be needed to add the client config to gpu's tests.
>
> authors=kbr@,aiolos@
>
> BUG=466877
>
> Committed: https://crrev.com/6bdfb7dfb3ce2e571697629895089cffc42b48e6
> Cr-Commit-Position: refs/heads/master@{#351196}
TBR=phajdan.jr@chromium.org,dpranke@chromium.org,kbr@chromium.org,maruel@chromium.org,piman@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466877
Committed: https://crrev.com/a2bab8d5dd883b6452420e6d776f00306526f0be
Cr-Commit-Position: refs/heads/master@{#351256}
Patch Set 1 #
Messages
Total messages: 5 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
