Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1379323002: [runtime] Share constructor/non-constructor bound function maps. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Share constructor/non-constructor bound function maps. Properly share both the constructor and the non-constructor maps for bound functions. Previously we had only the non-constructor map shared on the native context, and we had to create a new map for every bound function whose [[BoundTargetFunction]] is a constructor (in the ES6 sense). This should repair the most recent regression on Speedometer. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg R=jarin@chromium.org BUG=chromium:536114, chromium:535408, v8:4430 LOG=n Committed: https://crrev.com/6f81ee6a3de999380927730ce6f00958c93d2044 Cr-Commit-Position: refs/heads/master@{#31086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M src/bootstrapper.cc View 1 chunk +13 lines, -3 lines 0 comments Download
M src/contexts.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-02 10:12:31 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379323002/1
5 years, 2 months ago (2015-10-02 10:13:26 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_layout_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_layout_dbg/builds/1681)
5 years, 2 months ago (2015-10-02 12:19:47 UTC) #5
Jarin
lgtm (modulo the failing layout tests)
5 years, 2 months ago (2015-10-02 13:21:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379323002/1
5 years, 2 months ago (2015-10-02 14:14:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_layout_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_layout_dbg/builds/1683)
5 years, 2 months ago (2015-10-02 16:15:22 UTC) #10
Benedikt Meurer
On 2015/10/02 13:21:37, Jarin wrote: > lgtm (modulo the failing layout tests) Thanks. The blink ...
5 years, 2 months ago (2015-10-02 16:48:22 UTC) #11
Benedikt Meurer
On 2015/10/02 16:48:22, Benedikt Meurer wrote: > On 2015/10/02 13:21:37, Jarin wrote: > > lgtm ...
5 years, 2 months ago (2015-10-02 16:49:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379323002/1
5 years, 2 months ago (2015-10-02 16:49:39 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 16:51:26 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 16:51:42 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f81ee6a3de999380927730ce6f00958c93d2044
Cr-Commit-Position: refs/heads/master@{#31086}

Powered by Google App Engine
This is Rietveld 408576698