Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1379313002: [es6] Implement parts of the Reflect object. (Closed)

Created:
5 years, 2 months ago by neis
Modified:
5 years, 2 months ago
Reviewers:
rossberg, PhistucK
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Implement parts of the Reflect object. - Reflect.deleteProperty - Reflect.get - Reflect.has - Reflect.isExtensible Reflect.get doesn't support the receiver argument yet, and some of the others don't support proxies yet. R=rossberg BUG=v8:3931 LOG=n Committed: https://crrev.com/09184acad233389bab5acf12579c4e015d84446b Cr-Commit-Position: refs/heads/master@{#31146}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Total comments: 1

Patch Set 3 : #

Total comments: 1

Patch Set 4 : Rebase and use strict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -4 lines) Patch
M src/bootstrapper.cc View 1 2 3 2 chunks +20 lines, -2 lines 0 comments Download
M src/builtins.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +113 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A test/mjsunit/harmony/reflect.js View 1 2 3 1 chunk +210 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
neis
5 years, 2 months ago (2015-10-02 08:47:15 UTC) #1
PhistucK
It would be great if you could add BUG=v8:3931. :)
5 years, 2 months ago (2015-10-03 18:14:15 UTC) #2
PhistucK
5 years, 2 months ago (2015-10-03 18:15:51 UTC) #4
rossberg
https://codereview.chromium.org/1379313002/diff/1/test/mjsunit/harmony/reflect.js File test/mjsunit/harmony/reflect.js (right): https://codereview.chromium.org/1379313002/diff/1/test/mjsunit/harmony/reflect.js#newcode16 test/mjsunit/harmony/reflect.js:16: (function testReflectGetOnNonObject() { `null` always is a good candidate ...
5 years, 2 months ago (2015-10-05 13:30:00 UTC) #5
neis
https://codereview.chromium.org/1379313002/diff/1/test/mjsunit/harmony/reflect.js File test/mjsunit/harmony/reflect.js (right): https://codereview.chromium.org/1379313002/diff/1/test/mjsunit/harmony/reflect.js#newcode16 test/mjsunit/harmony/reflect.js:16: (function testReflectGetOnNonObject() { On 2015/10/05 13:30:00, rossberg wrote: > ...
5 years, 2 months ago (2015-10-07 09:58:33 UTC) #6
rossberg
lgtm https://codereview.chromium.org/1379313002/diff/20001/test/mjsunit/harmony/reflect.js File test/mjsunit/harmony/reflect.js (right): https://codereview.chromium.org/1379313002/diff/20001/test/mjsunit/harmony/reflect.js#newcode85 test/mjsunit/harmony/reflect.js:85: for (var i = 0; i < objects.length; ...
5 years, 2 months ago (2015-10-07 10:31:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379313002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379313002/40001
5 years, 2 months ago (2015-10-07 11:12:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6435)
5 years, 2 months ago (2015-10-07 11:14:29 UTC) #12
rossberg
https://codereview.chromium.org/1379313002/diff/40001/test/mjsunit/harmony/reflect.js File test/mjsunit/harmony/reflect.js (right): https://codereview.chromium.org/1379313002/diff/40001/test/mjsunit/harmony/reflect.js#newcode86 test/mjsunit/harmony/reflect.js:86: var tgt = prepare(obj); Nit: no need for this ...
5 years, 2 months ago (2015-10-07 11:15:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379313002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379313002/60001
5 years, 2 months ago (2015-10-07 11:24:29 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-07 11:45:17 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 11:45:36 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/09184acad233389bab5acf12579c4e015d84446b
Cr-Commit-Position: refs/heads/master@{#31146}

Powered by Google App Engine
This is Rietveld 408576698