Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1379263002: Don't use pairwise keyframe interpolation at fractions 0 and 1. (Closed)

Created:
5 years, 2 months ago by alancutter (OOO until 2018)
Modified:
5 years, 2 months ago
Reviewers:
dstockwell
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_listInterpolationFunctions
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use pairwise keyframe interpolation at fractions 0 and 1. This change modifies InvalidatableStyleInterpolations to treat fractions 0 and 1 as non-pairwise. At these fractions only the respective start or end keyframe will be used to produce an InterpolationValue. This change prevents us from using features from both keyframes when only one should apply at these fractions. Example: element.animate([{ backgroundImage: 'url(a), url(b)', }, { backgroundImage: 'url(c)', }, { duration: 1000, fill: 'forwards', }); This animation should fill forwards as 'url(c)' and not 'url(c), url(c)'. BUG=442163 Committed: https://crrev.com/70ab39994327394f7df9ae8d5aab8db76a114ea3 Cr-Commit-Position: refs/heads/master@{#353939}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review changes #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -38 lines) Patch
M third_party/WebKit/Source/core/animation/InvalidatableStyleInterpolation.h View 1 2 2 chunks +13 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableStyleInterpolation.cpp View 1 2 4 chunks +51 lines, -34 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alancutter (OOO until 2018)
5 years, 2 months ago (2015-10-02 03:44:43 UTC) #2
dstockwell
lgtm https://codereview.chromium.org/1379263002/diff/1/third_party/WebKit/Source/core/animation/InvalidatableStyleInterpolation.h File third_party/WebKit/Source/core/animation/InvalidatableStyleInterpolation.h (right): https://codereview.chromium.org/1379263002/diff/1/third_party/WebKit/Source/core/animation/InvalidatableStyleInterpolation.h#newcode45 third_party/WebKit/Source/core/animation/InvalidatableStyleInterpolation.h:45: , m_isCachePending(true) Perhaps invert this, m_isCached?
5 years, 2 months ago (2015-10-02 03:55:58 UTC) #3
alancutter (OOO until 2018)
https://codereview.chromium.org/1379263002/diff/1/third_party/WebKit/Source/core/animation/InvalidatableStyleInterpolation.h File third_party/WebKit/Source/core/animation/InvalidatableStyleInterpolation.h (right): https://codereview.chromium.org/1379263002/diff/1/third_party/WebKit/Source/core/animation/InvalidatableStyleInterpolation.h#newcode45 third_party/WebKit/Source/core/animation/InvalidatableStyleInterpolation.h:45: , m_isCachePending(true) On 2015/10/02 at 03:55:58, dstockwell wrote: > ...
5 years, 2 months ago (2015-10-08 05:18:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379263002/40001
5 years, 2 months ago (2015-10-14 00:06:37 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-14 02:13:41 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 02:14:30 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/70ab39994327394f7df9ae8d5aab8db76a114ea3
Cr-Commit-Position: refs/heads/master@{#353939}

Powered by Google App Engine
This is Rietveld 408576698