Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 1379243002: Fix PNG decoding divide by zero error due to zero row count. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix PNG decoding divide by zero error due to zero row count. BUG=537790 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/095a83c59120c108d9ac6f0ab71fd3faa5eea810

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M core/src/fxcodec/codec/fx_codec_flate.cpp View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
Lei Zhang
5 years, 2 months ago (2015-10-02 02:05:33 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1379243002/diff/1/core/src/fxcodec/codec/fx_codec_flate.cpp File core/src/fxcodec/codec/fx_codec_flate.cpp (right): https://codereview.chromium.org/1379243002/diff/1/core/src/fxcodec/codec/fx_codec_flate.cpp#newcode403 core/src/fxcodec/codec/fx_codec_flate.cpp:403: if (row_count <= 0) Yeah, ok, but this ...
5 years, 2 months ago (2015-10-02 16:44:25 UTC) #3
Lei Zhang
Committed patchset #1 (id:1) manually as 095a83c59120c108d9ac6f0ab71fd3faa5eea810 (presubmit successful).
5 years, 2 months ago (2015-10-02 17:27:48 UTC) #4
Lei Zhang
https://codereview.chromium.org/1379243002/diff/1/core/src/fxcodec/codec/fx_codec_flate.cpp File core/src/fxcodec/codec/fx_codec_flate.cpp (right): https://codereview.chromium.org/1379243002/diff/1/core/src/fxcodec/codec/fx_codec_flate.cpp#newcode403 core/src/fxcodec/codec/fx_codec_flate.cpp:403: if (row_count <= 0) On 2015/10/02 16:44:25, Tom Sepez ...
5 years, 2 months ago (2015-10-02 17:29:31 UTC) #5
Lei Zhang
5 years, 2 months ago (2015-10-02 19:30:46 UTC) #6
Message was sent while issue was closed.
Whoops, should have been BUG=537780.

Powered by Google App Engine
This is Rietveld 408576698