net/quic/quic_connection_test.cc - Issue 137923007: Refactor QuicSentPacketManager::MarkPacketHandled to simplify

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_connection_test.cc

Issue 137923007: Refactor QuicSentPacketManager::MarkPacketHandled to simplify (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_connection_test.cc

diff --git a/net/quic/quic_connection_test.cc b/net/quic/quic_connection_test.cc

index 8cdd5d82a01b7469da1a963ba9ccb45e54942f77..5636363093d035190bc6c3d87fedf0e86a0039a5 100644

--- a/net/quic/quic_connection_test.cc

+++ b/net/quic/quic_connection_test.cc

@@ -1847,7 +1847,9 @@ TEST_F(QuicConnectionTest, RetransmitWriteBlockedAckedOriginalThenSent) {

ProcessAckPacket(&ack);

connection_.OnPacketSent(WriteResult(WRITE_STATUS_OK, 0));

- EXPECT_TRUE(connection_.GetRetransmissionAlarm()->IsSet());

+ // The retransmission alarm should not be set because there are

+ // no unacked packets.

+ EXPECT_FALSE(connection_.GetRetransmissionAlarm()->IsSet());

}

TEST_F(QuicConnectionTest, ResumptionAlarmWhenWriteBlocked) {

« no previous file with comments | « no previous file | net/quic/quic_sent_packet_manager.cc » ('j') | no next file with comments »